Skip to content

docs: add in some notes on how to skip tests in the contributing docs #17925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 128 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
128 commits
Select commit Hold shift + click to select a range
5cc4a9c
Add changelog for 3.3.0-RC1
Kordyjan Jan 23, 2023
5522929
Fix incorrect TASTy version
Kordyjan Jan 26, 2023
57a6de2
Add changelog for 3.3.0-RC2
Kordyjan Jan 26, 2023
8dbc905
Release 3.3.0-RC2
Kordyjan Jan 26, 2023
c188f1d
Added jpath check to `ClassLikeSupport` getParentsAsTreeSymbolTuples
yzia2000 Jan 24, 2023
7ee369f
Backport "Added jpath check to `ClassLikeSupport` getParentsAsTreeSym…
Kordyjan Feb 15, 2023
92c5dad
Split out immutable GadtConstraint
dwijnand Dec 30, 2022
58d0a29
Rename GadtConstraintHandling to GadtState
dwijnand Jan 24, 2023
abbb549
Avoid bidirectional GADT typebounds from fullBounds
dwijnand Feb 13, 2023
6d141f3
Drop failsafe checkNonCyclic and document GADT fullBounds change
dwijnand Feb 14, 2023
4cc0e0d
GADT: move dropping GADT symbols into foldLeft
dwijnand Feb 15, 2023
5453d5c
GADT: Use isPatternBound, ofc...
dwijnand Feb 15, 2023
ace96f7
GADT: Use =:= instead of Any/Nothing
dwijnand Feb 15, 2023
67671ef
Backport "Avoid bidirectional GADT typebounds from fullBounds" (#16945)
Kordyjan Feb 17, 2023
fad1584
Fix static lazy field holder for GraalVM
szymon-rd Feb 1, 2023
e466fa4
No need to reset JavaStatic as its removed with the amsk
szymon-rd Feb 1, 2023
ef8e855
Removing getStaticFieldOffset as it's not used anymore
szymon-rd Feb 1, 2023
2bfbe75
Revert deletion of getStaticFieldOffset for now
szymon-rd Feb 2, 2023
41cfb62
Update printing tests to have matching AST
szymon-rd Feb 3, 2023
5803809
Backport "Fix static lazy field holder for GraalVM " (#16946)
Kordyjan Feb 17, 2023
805c49f
Add support for disabling redirected output in the REPL driver for us…
vasilmkd Feb 2, 2023
b36f319
Add scaladoc documentation for `ReplDriver#redirectOutput`
vasilmkd Feb 6, 2023
ebb2eb5
Backport "Add support for disabling redirected output in the REPL dri…
Kordyjan Feb 17, 2023
ff006d0
Add missing criterion to subtype check
odersky Feb 11, 2023
a9e4da9
Backport "Add missing criterion to subtype check" (#16948)
Kordyjan Feb 17, 2023
f3347db
Avoid timeouts in community–build-C
nicolasstucki Jan 18, 2023
8562128
Add changelog for 3.3.0-RC3
Kordyjan Feb 17, 2023
b3c1c98
Release 3.3.0-RC3
Kordyjan Feb 17, 2023
014be6f
Fix HK quoted pattern type variables
nicolasstucki Feb 14, 2023
aecbfa7
Fix HK quoted pattern type variables (#16980)
Kordyjan Feb 21, 2023
f0f6baf
Fix caching issue caused by incorrect isProvisional check
smarter Feb 21, 2023
1a77625
Fix race condition in new LazyVals
szymon-rd Feb 20, 2023
4a7e92b
Do not depend on runtime lib in tests
szymon-rd Feb 20, 2023
5801262
Disable test for Scalajs
szymon-rd Feb 27, 2023
81c6d6e
Add comment describing why LazyValControlState extends Serializable
szymon-rd Feb 27, 2023
63ff068
Backport "Fix race condition in new LazyVals" (#17247)
Kordyjan Apr 14, 2023
786035e
Backport "Fix caching issue caused by incorrect isProvisional check" …
Kordyjan Apr 14, 2023
aa601a1
Fix #16822
PaulCoral Feb 15, 2023
85fa542
Register usage of symbols in non-inferred type trees in CheckUnused
KacperFKorban Feb 16, 2023
ab28b09
Traverse annotations instead of just registering
PaulCoral Feb 18, 2023
d4f8c74
Ignore parameter of accessors
PaulCoral Feb 18, 2023
49686f8
Improve override detection in CheckUnused
PaulCoral Feb 19, 2023
e03fa1b
WUnused: Fix unused warnining in synthetic symbols
szymon-rd Feb 27, 2023
606608a
Move tests
szymon-rd Feb 28, 2023
b050bda
Remove unused import
szymon-rd Feb 28, 2023
2d41b46
Fix WUnused with indents in derived code
szymon-rd Mar 13, 2023
87d9e94
Add failsafe for a case where prefixes in CheckUnused/prepareIndent f…
szymon-rd Mar 13, 2023
8bdef2f
Fix for formatting and traverse call of inlined tree in wunused
szymon-rd Mar 14, 2023
813a43b
Add test for wunused Inlined call
szymon-rd Mar 14, 2023
06acf90
WUnused: Fix for symbols with synthetic names and unused transparent …
szymon-rd Mar 7, 2023
0f6c42e
Adjust assertions in test
szymon-rd Mar 8, 2023
fbc6501
Check if import contains transparent inline in registerImport
szymon-rd Mar 10, 2023
4070dbd
Warn for synthetic using/givens with wunused
szymon-rd Mar 28, 2023
4644e5e
Wunused: only filter out non-zero span-length givens
szymon-rd Mar 28, 2023
b72eade
Skip all symbols with $ in name in Wunused
szymon-rd Mar 29, 2023
432e829
Add a failing case with named using to test Wunused:implicits
szymon-rd Mar 29, 2023
24080f1
Replace for with exists in isTransparentInline in WUNused
szymon-rd Mar 29, 2023
7cbdadf
Skip extension method params in WUnused
szymon-rd Mar 29, 2023
ac06033
Fix wunused false positive when deriving alias type
szymon-rd Mar 27, 2023
41e7418
Fix wunused for deriving alias type that has a different name
szymon-rd Apr 3, 2023
8262192
Fix test for wunused alias deriving
szymon-rd Apr 3, 2023
fd70247
Fix selecting unaliased selector in wunused
szymon-rd Apr 4, 2023
ec298fa
Dealias only conditionally when symbol is derived val type in wunused
szymon-rd Apr 10, 2023
87f8449
Fix WUnused for accessible symbols that are renamed
szymon-rd Mar 29, 2023
0d2977e
Compare simple name and handle NO_NAME case in WUnused
szymon-rd Apr 12, 2023
c6a6656
Extracted isRenamedSymbol def
szymon-rd Apr 12, 2023
79b87a0
Fix isRenamedSymbol method in WUnused
szymon-rd Apr 12, 2023
2a2a111
Fix WUnused false positive in for
szymon-rd Mar 29, 2023
fd7b962
Do not register used symbol when position doesnt exist in wunused
szymon-rd Apr 13, 2023
6356a39
Make CheckUnused run both after Typer and Inlining
szymon-rd Apr 4, 2023
774c4e9
Fix instantation of CheckUnused phase
szymon-rd Apr 13, 2023
a69b49f
Remove unnecessary logging in CheckUnused phase
szymon-rd Apr 13, 2023
7966b5c
Add test cases for macro wunused
szymon-rd Apr 13, 2023
644fee2
Apply review suggestions to WUnused PR
szymon-rd Apr 13, 2023
e369d90
Move finishAggregation to UnusedData class in CheckUnused
szymon-rd Apr 13, 2023
03dba67
WIP: Disable WUnused for params of non-private defs
szymon-rd Apr 10, 2023
7017b8e
Handle implicit params and adjust tests in WUnused
szymon-rd Apr 13, 2023
b4e5cb7
Fix tests for WUnused/disable for public defs
szymon-rd Apr 13, 2023
2af117f
Add missing test for Wunused
Kordyjan Apr 14, 2023
84458c7
Bring in #17263 to fix the tests.
szymon-rd Apr 14, 2023
ff8e9f7
Backport "Fix #16822" (#17267)
Kordyjan Apr 17, 2023
5d76f39
Backport "Register usage of symbols in non-inferred type trees in Che…
Kordyjan Apr 17, 2023
ebba1cc
Backport "Traverse annotations instead of just registering, fixes #16…
Kordyjan Apr 17, 2023
20ebba5
Backport "Ignore parameter of accessors, fixes #16955" (#17270)
Kordyjan Apr 17, 2023
942476c
Backport "Improve override detection in CheckUnused, fixes #16865" (#…
Kordyjan Apr 17, 2023
cf6da33
Backport "WUnused: Fix unused warning in synthetic symbols" (#17272)
Kordyjan Apr 17, 2023
1615cd2
Backport "Fix WUnused with idents in derived code " (#17273)
Kordyjan Apr 17, 2023
423bd1e
Backport "WUnused: Fix for symbols with synthetic names and unused tr…
Kordyjan Apr 17, 2023
ae37e68
Backport "Skip extension method params in WUnused" (#17275)
Kordyjan Apr 17, 2023
5e866e3
Backport "Fix wunused false positive when deriving alias type" (#17276)
Kordyjan Apr 17, 2023
a6eee4f
Backport "Fix WUnused for accessible symbols that are renamed" (#17277)
Kordyjan Apr 17, 2023
29bc3db
Backport "Fix WUnused false positive in for" (#17278)
Kordyjan Apr 17, 2023
c043299
Backport "Make CheckUnused run both after Typer and Inlining" (#17279)
Kordyjan Apr 17, 2023
7809f9b
Backport "Disable WUnused for params of non-private defs" (#17280)
Kordyjan Apr 17, 2023
3156fe9
Check the status of coursier download in CoursierScalaTests.scala
anatoliykmetyuk Mar 17, 2023
22e6ffe
Add changelog for 3.3.0-RC4
Kordyjan Apr 17, 2023
5990252
Release 3.3.0-RC4
Kordyjan Apr 17, 2023
40502e0
Drop network tests in requests community-build
mbovel Apr 3, 2023
72e5dd2
Fix compiler crash in WUnused
szymon-rd Apr 25, 2023
46d9c07
Change the order of checks
szymon-rd Apr 25, 2023
716b867
Wunused: Check if symbol exists before isValidMemberDef check
KacperFKorban Apr 19, 2023
12cd96e
Wunused: Include import selector bounds in unused checks
KacperFKorban Apr 20, 2023
74b0aa4
Remove experimental from Mirror#fromProductTyped
mpilquist Feb 4, 2023
a55322d
Update experimental definitions list
mpilquist Feb 4, 2023
a784926
Backport "Fix compiler crash in WUnused" (#17356)
Kordyjan Apr 26, 2023
14237d3
Backport "Wunused: Check if symbol exists before isValidMemberDef che…
Kordyjan Apr 26, 2023
d64378b
Backport "Wunused: Include import selector bounds in unused checks" (…
Kordyjan Apr 26, 2023
f079936
Backport "Remove experimental from Mirror#fromProductTyped" (#17353)
Kordyjan Apr 27, 2023
909b56c
Add changelog for 3.3.0-RC5
Kordyjan Apr 27, 2023
597144e
Release 3.3.0-RC5
Kordyjan Apr 27, 2023
3b9b83d
Patmat: Use less type variables in prefix inference
dwijnand Feb 3, 2023
752ad2f
Backport "Patmat: Use less type variables in prefix inference" (#17440)
Kordyjan May 9, 2023
9c1cdc8
Fix #17187: allow patches with same span
adpi2 Apr 28, 2023
c1028a2
Revert exact match in overlaps
adpi2 May 1, 2023
9a1e7cb
Raise a warning instead of an error for a type ascription on a patter…
prolativ May 10, 2023
16d68f6
* Preserve the more restrictive syntax for typed patterns in the lang…
prolativ May 11, 2023
4f2e819
Backport "Just warn on type ascription on a pattern" (#17477)
Kordyjan May 12, 2023
6629e13
Backport "Fix #17187: allow patches with same span" (#17476)
Kordyjan May 12, 2023
58256dd
Add changelog for 3.3.0-RC6
Kordyjan May 12, 2023
9bae88a
Release 3.3.0-RC6
Kordyjan May 12, 2023
410e5df
Set TASTy Version to 28.3.0
Kordyjan May 23, 2023
92152f4
Add changelog for 3.3.0
Kordyjan May 23, 2023
5879ff1
Release 3.3.0
Kordyjan May 23, 2023
3705c21
Merge branch 'release-3.3.0' into language-reference-stable
Kordyjan May 25, 2023
0fa1c91
Add info about 3.3 to source compat doc
Kordyjan May 29, 2023
724340e
Update docs/_docs/reference/language-versions/source-compatibility.md
Kordyjan May 30, 2023
8810943
Merge 3.3.0 reference (#17587)
Kordyjan May 30, 2023
232180f
Update source-compatibility.md
bishabosha May 30, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Extracted isRenamedSymbol def
  • Loading branch information
szymon-rd authored and Kordyjan committed Apr 14, 2023
commit c6a6656c7002ef6b3da108d2d35fdeaee4a2adfd
4 changes: 3 additions & 1 deletion compiler/src/dotty/tools/dotc/transform/CheckUnused.scala
Original file line number Diff line number Diff line change
Expand Up @@ -603,11 +603,13 @@ object CheckUnused:
case (sel, sym) if dealias(sym) == dealiasedSym => sel
}.headOption else None
def wildcard = sels.find(sel => sel.isWildcard && ((sym.is(Given) == sel.isGiven) || sym.is(Implicit)))
if qualHasSymbol && (!isAccessible || (sym.name != nme.NO_NAME && symName.exists(_.toSimpleName != sym.name.toSimpleName))) && sym.exists then
if qualHasSymbol && (!isAccessible || isRenamedSymbol(sym, symName)) && sym.exists then
selector.orElse(dealiasedSelector).orElse(wildcard) // selector with name or wildcard (or given)
else
None

private def isRenamedSymbol(sym: Symbol, symNameInScope: Option[Name]) =
sym.name != nme.NO_NAME && symName.exists(_.toSimpleName != sym.name.toSimpleName)

private def dealias(symbol: Symbol)(using Context): Symbol =
if(symbol.isType && symbol.asType.denot.isAliasType) then
Expand Down