Scaladoc is years before the language and creates `opaque object`s

[KacperFKorban]

Compiler version

3.6.0-RC1-bin-20240718-bd84584-NIGHTLY, 3.4.2

Minimized code

//> using scala 3.nightly
// opaqueobject.scala

object Sth:
  opaque type A = Int

scala-cli doc opaqueobject.scala

Output

The object documentation also gets an opaque modifier.
The opaque type is documented correctly.

Expectation

The object documentation doesn't have an opaque modifier

[odersky]

It's not really opaque types. The compiler uses internally opaque as a flag for the object or class containing an opaque type. That won't change. It should be the job of the scaladoc to filter that out.

[mbovel]

We could probably filter out opaque in parseObject?

scala3/scaladoc/src/dotty/tools/scaladoc/tasty/ClassLikeSupport.scala

Lines 314 to 319 in b8c5ecb

	def parseObject(classDef: ClassDef, signatureOnly: Boolean = false): Member =
	mkClass(classDef)(
	// All objects are final so we do not need final modifier!
	modifiers = classDef.symbol.getExtraModifiers().filter(_ != Modifier.Final),
	signatureOnly = signatureOnly
	)

Or could we directly remove opaque from def getExtraModifiers()?

cc @Florian3k

[KacperFKorban]

@mbovel Yes, it seems like the correct solution. (I meant the one in parseObject 😅)

[Florian3k]

Filtering should be fine. Not so sure about removing it from getExtraModifiers.