Merge pull request #2904 from dotty-staging/fix-#2564

Fix #2564: Do not create ill-formed <init> accessors

Author: DarkDimius

compiler/src/dotty/tools/dotc/typer/Inliner.scala

@@ -144,9 +144,14 @@ object Inliner {
           case _: Apply | _: TypeApply | _: RefTree if needsAccessor(tree.symbol) =>
             if (tree.isTerm) {
               val (methPart, targs, argss) = decomposeCall(tree)
-              addAccessor(tree, methPart, targs, argss,
-                  accessedType = methPart.tpe.widen,
-                  rhs = (qual, tps, argss) => qual.appliedToTypes(tps).appliedToArgss(argss))
+              if (methPart.symbol.isConstructor && needsAccessor(methPart.symbol)) {
+                ctx.error("Cannot use private constructors in inline methods", tree.pos)
+                tree // TODO: create a proper accessor for the private constructor
+              } else {
+                addAccessor(tree, methPart, targs, argss,
+                    accessedType = methPart.tpe.widen,
+                    rhs = (qual, tps, argss) => qual.appliedToTypes(tps).appliedToArgss(argss))
+              }
             } else {
               // TODO: Handle references to non-public types.
               // This is quite tricky, as such types can appear anywhere, including as parts

tests/neg/i2564.scala

@@ -0,0 +1,4 @@
+object Foo {
+  inline def bar = new Bar // error
+  class Bar private[Foo]()
+}

tests/neg/i2564b.scala

@@ -0,0 +1,3 @@
+class Foo private() {
+  inline def foo = new Foo // error
+}