TastyFormat#numRefs: Properly handle implicit/erased method types

smarter · smarter · commit 3dc3b19fb951 · 2018-11-22T17:08:06.000+01:00
I don't have a test case but the previous definition was definitely wrong.
diff --git a/compiler/src/dotty/tools/dotc/core/tasty/TastyFormat.scala b/compiler/src/dotty/tools/dotc/core/tasty/TastyFormat.scala
@@ -649,7 +649,8 @@ object TastyFormat {
     case VALDEF | DEFDEF | TYPEDEF | OBJECTDEF | TYPEPARAM | PARAM | NAMEDARG | RETURN | BIND |
          SELFDEF | REFINEDtype | TERMREFin | TYPEREFin | HOLE => 1
     case RENAMED | PARAMtype => 2
-    case POLYtype | METHODtype | TYPELAMBDAtype => -1
+    case POLYtype | METHODtype | IMPLICITMETHODtype | ERASEDMETHODtype | ERASEDIMPLICITMETHODtype |
+         TYPELAMBDAtype => -1
     case _ => 0
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -649,7 +649,8 @@ object TastyFormat {`
`649`	`649`	`case VALDEF \| DEFDEF \| TYPEDEF \| OBJECTDEF \| TYPEPARAM \| PARAM \| NAMEDARG \| RETURN \| BIND \|`
`650`	`650`	`SELFDEF \| REFINEDtype \| TERMREFin \| TYPEREFin \| HOLE => 1`
`651`	`651`	`case RENAMED \| PARAMtype => 2`
`652`		`- case POLYtype \| METHODtype \| TYPELAMBDAtype => -1`
	`652`	`+ case POLYtype \| METHODtype \| IMPLICITMETHODtype \| ERASEDMETHODtype \| ERASEDIMPLICITMETHODtype \|`
	`653`	`+ TYPELAMBDAtype => -1`
`653`	`654`	`case _ => 0`
`654`	`655`	`}`
`655`	`656`	`}`