Skip to content

Update Mill to 0.11.1, migrate script to millw #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

lolgab
Copy link
Contributor

@lolgab lolgab commented Jun 24, 2023

No description provided.

@SethTisue
Copy link
Member

Can you suggest a reviewer? If not, I'm happy to hit "merge".

@lolgab
Copy link
Contributor Author

lolgab commented Jun 28, 2023

Sure! @lefou can you give a look?

Copy link
Contributor

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR replaces the mill script with millw 0.4.7, which is a bit more complex but able to handle all older Mill versions in case someone edits the .mill-version file.

@lolgab
Copy link
Contributor Author

lolgab commented Jun 28, 2023

I default to use millw as the mill script. I can also use the latest version of the official mill script which is smaller and similar to the current script.

@SethTisue SethTisue self-assigned this Jun 29, 2023
@SethTisue SethTisue merged commit d23d599 into scala:main Jul 12, 2023
@lolgab lolgab deleted the update-mill branch July 12, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants