Skip to content

Backport "Only check seen for LazyRef for TypeSizeAccumulator" to 3.3 LTS #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Backport "Only check seen for LazyRef for TypeSizeAccumulator" to 3.3 LTS #592

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4f31f01
Remove seen from TypeSizeAccumulator
May 23, 2024
9d5bb69
Do seen check only for LazyRef
eejbyfeldt Jul 5, 2025
39b3db3
Only track types in from LazyRef
eejbyfeldt Sep 16, 2025
fce6922
bugfix: Fix duplicate option in TyperOps
tgodzik Sep 26, 2025
6c20869
Remove obsolete unused options
som-snytt Aug 15, 2025
48de883
Report unused masking import selectors
som-snytt Aug 15, 2025
98a0ccb
Remove obsolete unused options
som-snytt Aug 15, 2025
24d7699
bugfix: Fix issues after backports
tgodzik Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Only track types in from LazyRef 
[Cherry-picked 8a0bbdf]
  • Loading branch information
@eejbyfeldt @tgodzik
eejbyfeldt authored and tgodzik committed Sep 26, 2025
commit 39b3db3738bde35d2f8cfc96b92d38c2b59ba60b
8 changes: 5 additions & 3 deletions compiler/src/dotty/tools/dotc/core/Types.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6587,7 +6587,6 @@ object Types extends TypeUtils {
class TypeSizeAccumulator(using Context) extends TypeAccumulator[Int] {
var seen = util.HashSet[Type](initialCapacity = 8)
def apply(n: Int, tp: Type): Int =
seen += tp
tp match {
case tp: AppliedType =>
val tpNorm = tp.tryNormalize
Expand All @@ -6599,8 +6598,11 @@ object Types extends TypeUtils {
apply(n, tp.superType)
case tp: TypeParamRef =>
apply(n, TypeComparer.bounds(tp))
case tp: LazyRef if seen.contains(tp) =>
n
case tp: LazyRef =>
if seen.contains(tp) then n
else
seen += tp
foldOver(n, tp)
case _ =>
foldOver(n, tp)
}
Expand Down