Don't expand the name of accessors

I couldn't find a single use case where this is needed.
The callee is usually either not an accessor
or all declarations in scope are looped over and expanded.

On the other hand this fixes a bug in specialization.
After all the accessor(s) could be implementing an abstract method.

Author: joroKr21

src/compiler/scala/tools/nsc/transform/ExtensionMethods.scala

@@ -115,7 +115,7 @@ abstract class ExtensionMethods extends Transform with TypingTransformers {
             extensionDefs(currentOwner.companionModule) = new mutable.ListBuffer[Tree]
             currentOwner.primaryConstructor.makeNotPrivate(NoSymbol)
             // scala/bug#7859 make param accessors accessible so the erasure can generate unbox operations.
-            currentOwner.info.decls.foreach(sym => if (sym.isParamAccessor && sym.isMethod) sym.makeNotPrivate(currentOwner))
+            currentOwner.info.decls.foreach(sym => if (sym.isParamAccessor) sym.makeNotPrivate(currentOwner))
             super.transform(tree)
           } else if (currentOwner.isStaticOwner) {
             super.transform(tree)

src/reflect/scala/reflect/internal/Symbols.scala

@@ -838,10 +838,9 @@ trait Symbols extends api.Symbols { self: SymbolTable =>
       isAbstractType && !isExistential && !isTypeParameterOrSkolem && isLocalToBlock
 
     /** change name by appending $$<fully-qualified-name-of-class `base`>
-     *  Do the same for any accessed symbols or setters/getters.
      *  Implementation in TermSymbol.
      */
-    def expandName(base: Symbol): Unit = { }
+    def expandName(base: Symbol): Unit = ()
 
     // In java.lang, Predef, or scala package/package object
     def isInDefaultNamespace = UnqualifiedOwners(effectiveOwner)
@@ -2987,19 +2986,10 @@ trait Symbols extends api.Symbols { self: SymbolTable =>
       this
     }
 
-    /** change name by appending $$<fully-qualified-name-of-class `base`>
-     *  Do the same for any accessed symbols or setters/getters
-     */
+    /** change name by appending $$<fully-qualified-name-of-class `base`> */
     override def expandName(base: Symbol): Unit = {
       if (!hasFlag(EXPANDEDNAME)) {
         setFlag(EXPANDEDNAME)
-        if (hasAccessorFlag && !isDeferred) {
-          accessed.expandName(base)
-        }
-        else if (hasGetter) {
-          getterIn(owner).expandName(base)
-          setterIn(owner).expandName(base)
-        }
         name = nme.expandedName(name.toTermName, base)
       }
     }

test/files/run/t12222.check

@@ -0,0 +1 @@
+0

test/files/run/t12222/Buffer_1.scala

@@ -0,0 +1,10 @@
+trait ABuffer[@specialized(Float)T] {
+  def count: Int
+}
+
+class Buffer[@specialized(Float) T](array_par: Array[T]) extends ABuffer[T] {
+  var array: Array[T] = array_par
+  var count: Int = 0
+}
+
+class Float32Buffer(array_par: Array[Float]) extends Buffer[Float](array_par)

test/files/run/t12222/Test_2.scala

@@ -0,0 +1,7 @@
+object Test {
+  def main(args: Array[String]): Unit = {
+    val vertices = Array[Float]()
+    val attribute = new Float32Buffer(vertices)
+    println(attribute.count)
+  }
+}

test/files/run/t3897.check

@@ -1,8 +1,8 @@
-(One$$messages,scala.collection.mutable.ListBuffer<java.lang.String>)
+(messages,scala.collection.mutable.ListBuffer<java.lang.String>)
 (One$$messages,scala.collection.mutable.ListBuffer<java.lang.String>)
 (messages,scala.collection.mutable.ListBuffer<java.lang.String>)
 (messages,scala.collection.mutable.ListBuffer<java.lang.String>)
-(One$$messages,scala.collection.mutable.ListBuffer<java.lang.String>)
+(messages,scala.collection.mutable.ListBuffer<java.lang.String>)
 (One$$messages,scala.collection.mutable.ListBuffer<java.lang.String>)
 (messages,scala.collection.mutable.ListBuffer<java.lang.String>)
 (messages,scala.collection.mutable.ListBuffer<java.lang.String>)