Skip to content

NamespaceBinding.buildString inproper handling of TopScope #45

Closed
@muntis

Description

@muntis

Starting with saca 2.11 NamespaceBinding.buildString uses private metohod doBuildString for namespace part generation. problem is that this method is not overrided in TopScope sub class. This generates unnecessary artifacts in form of empty (xmlns="") when constructing xml:

  def pretty(xml: Node) = new scala.xml.PrettyPrinter(200, 2).format(xml)
  val xx = <soapenv:Envelope xmlns:soapenv="aaa">
    <soapenv:Header xmlns:wsa="ssss">
    </soapenv:Header>
    <soapenv:Body><body xmlns:soapenv="aaa"></body></soapenv:Body>
  </soapenv:Envelope>
  println(pretty(xx))

Results in:

<soapenv:Envelope xmlns:soapenv="aaa" xmlns="">
  <soapenv:Header xmlns:wsa="ssss"> </soapenv:Header>
  <soapenv:Body>
    <body xmlns:soapenv="aaa"></body>
  </soapenv:Body>
</soapenv:Envelope>

In this example problem can be fixed by setting pscope=TopScope for PrettyPrinter, but it does not help if xml is build from multiple parts.

def pretty(xml: Node) = new scala.xml.PrettyPrinter(200, 2).format(xml, TopScope)
val body = <body xmlns:soapenv="aaa"></body>
val xx = <soapenv:Envelope xmlns:soapenv="aaa">
    <soapenv:Header xmlns:wsa="ssss">
    </soapenv:Header>
    <soapenv:Body>{body}</soapenv:Body>
    <soapenv:Body><body xmlns:soapenv="aaa"></body></soapenv:Body>
  </soapenv:Envelope>
println(pretty(xx))

Results in:

<soapenv:Envelope xmlns:soapenv="aaa">
  <soapenv:Header xmlns:wsa="ssss"> </soapenv:Header>
  <soapenv:Body>
    <body xmlns:soapenv="aaa" xmlns=""></body>
  </soapenv:Body>
  <soapenv:Body>
    <body xmlns:soapenv="aaa"></body>
  </soapenv:Body>
</soapenv:Envelope>

Sugested solution:

override def buildString(sb: StringBuilder, stop: NamespaceBinding) {
  NamespaceBinding.doBuildString(shadowRedefined(stop), sb, stop)
}


object NamespaceBinding{
  def doBuildString(b: NamespaceBinding, sb: StringBuilder, stop: NamespaceBinding) {
    if ((this == null) || (this eq stop)) return // contains?

    sb append " xmlns%s=\"%s\"".format(
      (if (b.prefix != null) ":" + b.prefix else ""),
      (if (b.uri != null) b.uri else "")
    )
    b.parent match {
      case binding: NamespaceBinding => doBuildString(binding, sb, stop)
      case TopScope =>
    }
  }
}

Or just change visibility of doBuildString and override it properly in TopScope like it's done with buildString methods

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions