Merge pull request #28 from ashawley/pretty-print-ns-defect

PrettyPrinter adds empty attribute with xmlns

Author: adriaanm

src/main/scala/scala/xml/PrettyPrinter.scala

@@ -244,7 +244,7 @@ class PrettyPrinter(width: Int, step: Int) {
    *  @param pscope the namespace to prefix mapping
    *  @return      the formatted string
    */
-  def format(n: Node, pscope: NamespaceBinding = null): String =
+  def format(n: Node, pscope: NamespaceBinding = TopScope): String =
     sbToString(format(n, pscope, _))
 
   /**

src/test/scala/scala/xml/XMLTest.scala

@@ -824,4 +824,16 @@ expected closing tag of foo
     }
   }
 
+  @UnitTest
+  def issue28: Unit = {
+    val x = <x:foo xmlns:x="gaga"/>
+    // val ns = new NamespaceBinding("x", "gaga", sc)
+    // val x = Elem("x", "foo", e, ns)
+    val pp = new xml.PrettyPrinter(80, 2)
+    // This assertion passed
+    assertEquals("""<x:foo xmlns:x="gaga"/>""", x.toString)
+    // This was the bug, producing an errant xmlns attribute
+    assertEquals("""<x:foo xmlns:x="gaga"/>""", pp.format(x))
+  }
+
 }