Offer warning when demonstrably non-side-effect...

paulp · adriaanm · commit 5b42beed69cd · 2013-07-17T09:40:38.000-07:00
Offer warning when demonstrably non-side-effecting expressions appear in
statement position, which should be unintentional by definition. Threw
in removal of six places with useless discarded expressions which the
warning informed me about. No review.
diff --git a/src/library/scala/xml/dtd/ContentModel.scala b/src/library/scala/xml/dtd/ContentModel.scala
@@ -52,7 +52,6 @@ object ContentModel extends WordExp {
       sb append sep
       buildString(z, sb)
     }
-    sb
   }
 
   def buildString(c: ContentModel, sb: StringBuilder): StringBuilder = c match {

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,6 @@ object ContentModel extends WordExp {`
`52`	`52`	`sb append sep`
`53`	`53`	`buildString(z, sb)`
`54`	`54`	`}`
`55`		`- sb`
`56`	`55`	`}`
`57`	`56`
`58`	`57`	`def buildString(c: ContentModel, sb: StringBuilder): StringBuilder = c match {`