This repository was archived by the owner on Sep 8, 2022. It is now read-only.
be compatible with more Scala versions #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see scala/scala#4640 for details. in that PR (targeted for 2.12.0-M3), we are making a binary incompatible change to Stream. by avoiding using Stream at all here, we avoid running afoul of the incompatibility. Stream is arguably overkill here anyway, Iterator is just fine. so there's no need to change the code back after we're over the M2/M3 incompatibility hump.
|
review by @lrytz |
|
LGTM! |
SethTisue
added a commit
that referenced
this pull request
Jul 20, 2015
be compatible with more Scala versions
|
ups, we forgot to update |
lrytz
pushed a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
be compatible with more Scala versions
lrytz
pushed a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
be compatible with more Scala versions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see scala/scala#4640 for details.
in that PR (targeted for 2.12.0-M3), we are making a binary
incompatible change to Stream. by avoiding using Stream at all here,
we avoid running afoul of the incompatibility.
Stream is arguably overkill here anyway, Iterator is just fine.
so there's no need to change the code back after we're over
the M2/M3 incompatibility hump.