fix Scaladoc generation (and check it in CI) (#584)

SethTisue · web-flow · commit 4499b0d9da51 · 2025-02-26T19:48:09.000-08:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -23,4 +23,4 @@ jobs:
         java-version: ${{matrix.java}}
     - uses: sbt/setup-sbt@v1
     - name: Test
-      run: sbt ++${{matrix.scala}} test headerCheck versionPolicyCheck package
+      run: sbt ++${{matrix.scala}} test doc headerCheck versionPolicyCheck package
diff --git a/build.sbt b/build.sbt
@@ -34,8 +34,6 @@ lazy val parserCombinators = crossProject(JVMPlatform, JSPlatform, NativePlatfor
     // go nearly warning-free, but only on 2.13, it's too hard across all versions
     Compile / scalacOptions ++= (CrossVersion.partialVersion(scalaVersion.value) match {
       case Some((2, 13)) => Seq("-Werror", "-Wunused",
-        // ideally we'd do something about this. `^?` is the responsible method
-        "-Wconf:site=scala.util.parsing.combinator.Parsers.*&cat=lint-multiarg-infix:i",
         // not sure what resolving this would look like? didn't think about it too hard
         "-Wconf:site=scala.util.parsing.combinator.lexical.StdLexical.*&cat=other-match-analysis:i",
       )

Original file line number	Diff line number	Diff line change
`@@ -34,8 +34,6 @@ lazy val parserCombinators = crossProject(JVMPlatform, JSPlatform, NativePlatfor`
`34`	`34`	`// go nearly warning-free, but only on 2.13, it's too hard across all versions`
`35`	`35`	`Compile / scalacOptions ++= (CrossVersion.partialVersion(scalaVersion.value) match {`
`36`	`36`	`case Some((2, 13)) => Seq("-Werror", "-Wunused",`
`37`		- // ideally we'd do something about this. `^?` is the responsible method
`38`		`- "-Wconf:site=scala.util.parsing.combinator.Parsers.*&cat=lint-multiarg-infix:i",`
`39`	`37`	`// not sure what resolving this would look like? didn't think about it too hard`
`40`	`38`	`"-Wconf:site=scala.util.parsing.combinator.lexical.StdLexical.*&cat=other-match-analysis:i",`
`41`	`39`	`)`