fix: update parent type of ParSeqLike
#308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting from Scala 3.8.0, the following code will not compile due to removing some unsound typing rules. See scala/scala3#23441 Co-authored-by: Eugene Flesselle <eugene@flesselle.net>
44 tasks
Member
Author
|
@SethTisue Can you please assign one of the maintainers as a reviewer for this PR. Thanks. |
Member
|
review by @scala/collections ...? |
He-Pin
reviewed
Sep 20, 2025
| * operation of `ParallelIterable` trait using the new `split` operation. | ||
| */ | ||
| trait ParSeqLike[+T, +CC[X] <: ParSeq[X], +Repr <: ParSeq[T], +Sequential <: scala.collection.Seq[T] with SeqOps[T, AnyConstr, Sequential]] | ||
| trait ParSeqLike[+T, +CC[X] <: ParSeq[X], +Repr <: ParSeq[T], +Sequential <: scala.collection.Seq[T] with SeqOps[T, collection.Seq, Sequential]] |
Member
Author
There was a problem hiding this comment.
Because we are putting constraints over the sequential type, not the parallel one.
Member
Author
There was a problem hiding this comment.
Also, this is just the right signature to have since Seq expects to have at least a Seq there. Same is done for ParIterableLike:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from Scala 3.8.0, the following code will not compile due to removing some unsound typing rules. See scala/scala3#23441 for more details.