Skip to content

add @unused. #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2020
Merged

add @unused. #373

merged 1 commit into from
Oct 13, 2020

Conversation

VladPodilnyk
Copy link
Contributor

@VladPodilnyk VladPodilnyk commented Oct 2, 2020

Solves: #369

@SethTisue
Copy link
Member

Thank you!

CI is failing because you need sign the Scala CLA before we could accept this:

Please sign the Scala CLA to contribute to scala/scala-collection-compat
Go to https://www.lightbend.com/contribute/cla/scala

@VladPodilnyk
Copy link
Contributor Author

Thanks for guiding me!
I've signed the CLA, but I guess it need some time to process an application. Do I need to trigger the build manually then?

@SethTisue
Copy link
Member

I've restarted CI.

@SethTisue
Copy link
Member

SethTisue commented Oct 2, 2020

Does this actually work on 2.11 and 2.12, or does providing it merely prevent cross-compilation from failing, like we did for @nowarn?

@VladPodilnyk
Copy link
Contributor Author

it should work on 2.11/2.12, l've tested and haven't spotted a warning for unused variable.

@SethTisue SethTisue merged commit 3dd2c48 into scala:master Oct 13, 2020
@SethTisue
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants