Fix #2433: spaces not being allowed in Paths on Windows #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acording to Windows documentation, merely characters with codes 0-31 are considered to be the forbidden control characters for paths. Since spaces (of code 32) are allowed, they were removed from the check. A test for the issue was also added.
ekrich
suggested changes
Nov 12, 2021
| def isSpaceOrReservedChar(c: Char) = { | ||
| c.isSpaceChar || pathReservedChars.contains(c) | ||
| def isControlOrReservedChar(c: Char) = { | ||
| c < '\u0020' || pathReservedChars.contains(c) |
There was a problem hiding this comment.
I would consider either val space = '\u0020' or leaving a comment at this location to make this a touch more readable. Other than that this looks great.
ekrich
approved these changes
Nov 12, 2021
WojciechMazur
approved these changes
Nov 16, 2021
WojciechMazur
pushed a commit
to WojciechMazur/scala-native
that referenced
this pull request
Nov 27, 2021
…cala-native#2434) * Fix spaces not being allowed on Paths on Windows Acording to Windows documentation, merely characters with codes 0-31 are considered to be the forbidden control characters for paths. Since spaces (of code 32) are allowed, they were removed from the check. A test for the issue was also added. * Make char exclusion more clear (cherry picked from commit 3c37e76)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Windows documentation, merely characters with codes 0-31 are considered to be the control characters forbidden for paths. Since spaces (of code 32) are allowed, they were removed from the check.
A test for the issue was also added.