Only fail JSEnv test if log is bad

Author: gzm0

js-envs/src/test/scala/org/scalajs/jsenv/test/JSEnvTest.scala

@@ -4,10 +4,12 @@ import org.scalajs.jsenv._
 
 import org.scalajs.core.tools.io.MemVirtualJSFile
 import org.scalajs.core.tools.classpath.PartialClasspath
-import org.scalajs.core.tools.logging.NullLogger
+import org.scalajs.core.tools.logging._
 
 import org.junit.Assert._
 
+import StoreLogger._
+
 abstract class JSEnvTest {
 
   protected def newJSEnv: JSEnv
@@ -25,9 +27,14 @@ abstract class JSEnvTest {
       newJSEnv.jsRunner(emptyCP, code, logger, console).run()
 
       val log = logger.getLog
+      val hasBadLog = log exists {
+        case Log(level, _) if level >= Level.Warn => true
+        case Trace(_) => true
+        case _ => false
+      }
 
-      assertTrue("VM shouldn't produce log. Log:\n" +
-          log.mkString("\n"), log.isEmpty)
+      assertFalse("VM shouldn't log errors, warnings or traces. Log:\n" +
+          log.mkString("\n"), hasBadLog)
       assertEquals("Output should match", expectedOut, console.getLog)
     }
 

js-envs/src/test/scala/org/scalajs/jsenv/test/StoreLogger.scala

@@ -21,9 +21,9 @@ class StoreLogger extends Logger {
 
 object StoreLogger {
 
-  abstract class LogElem
-  case class Log(level: Level, message: String) extends LogElem
-  case class Success(message: String) extends LogElem
-  case class Trace(t: Throwable) extends LogElem
+  sealed trait LogElem
+  final case class Log(level: Level, message: String) extends LogElem
+  final case class Success(message: String) extends LogElem
+  final case class Trace(t: Throwable) extends LogElem
 
 }