Added an example to the README #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
requested changes
Jan 22, 2022
| document.body.appendChild(newDiv) | ||
|
|
||
| // Find the element by id on the page, and compare the contents | ||
| assertEquals(document.getElementById(id).innerHTML, content) |
There was a problem hiding this comment.
Does MUnit reverse the meaning of the arguments to assertEquals? Normally the expected value is on the left, and the actual value on the right.
There was a problem hiding this comment.
Did not know that. I've always treated it like a predicate e.g. if index == 0.
There was a problem hiding this comment.
However, I think it does flip them:
test("assert") {
assertEquals(1, 2)
}gives
values are not the same
=> Obtained
1
=> Diff (- obtained, + expected)
-1
+2
|
LGTM. Could you squash everything in a single commit with a clean commit message, please? |
The purpose of adding this example is to demystify the plugins usage, hopefully making it easier for people to get started.
davesmith00000
force-pushed
the
patch-1
branch
from
56b32bf to
fc0ef72
Compare
|
Done, hopefully that's better. Sorry I was a bit hasty with the first version of the PR. |
sjrd
approved these changes
Jan 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the instructions a bit magical, so I thought I'd spell out the usage a bit for the next person interested in trying it.
Based on the jsdom docs I had it in my head that I was was going to have to create a jsdom instance myself. "Is this plugin giving me a nice way to do that?" I wondered ...but after I read the source code I realised that this plugin is fully setting up node.js with a running dom instance (of course... makes much more sense 🤦 ).
Anyway I hope this helps someone.