Skip to content

Add RequestInit#duplex #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 22, 2022
Merged

Add RequestInit#duplex #719

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0316e6c
Add duplex property for the Fetch API's Request type
zetashift Aug 20, 2022
87f489f
Minor newlines formatting
zetashift Aug 20, 2022
d68117b
Move duplex over to RequestInit as a var
zetashift Aug 20, 2022
cf5a973
Scalafix api reports
zetashift Aug 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move duplex over to RequestInit as a var
  • Loading branch information
@zetashift
zetashift committed Aug 20, 2022
commit d68117b978f9dd86363c179f57d5a45c756fafd0
5 changes: 0 additions & 5 deletions dom/src/main/scala/org/scalajs/dom/Request.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,4 @@ class Request(input: RequestInfo, init: RequestInit = null) extends Body {
def keepalive: Boolean = js.native

def signal: AbortSignal = js.native

/** "half" is the only valid value and it is for initiating a half-duplex fetch (i.e., the user agent sends the entire
* request before processing the response).
*/
def duplex: RequestDuplex = js.native
}
5 changes: 5 additions & 0 deletions dom/src/main/scala/org/scalajs/dom/RequestInit.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@ trait RequestInit extends js.Object {

var signal: js.UndefOr[AbortSignal] = js.undefined

/** "half" is the only valid value and it is for initiating a half-duplex fetch (i.e., the user agent sends the entire
* request before processing the response).
*/
var duplex: js.UndefOr[RequestDuplex] = js.undefined

/** The whatwg spec section on [[https://fetch.spec.whatwg.org/#requestinit RequestInit dictionary]] has a comment
* that states that this value "can only be set to null". In the detailed steps section for
* [[https://fetch.spec.whatwg.org/#dom-request the Request(input,init) constructor]] it says even more clearly: "If
Expand Down