Skip to content

Commit 37da9a6

Browse files
armanbilgearmanbilge
authored
Merge pull request #657 from scala-js/issue/624
Always use `var` and `undefined` for `new`-based constructors
2 parents b20fa78 + b8c8448 commit 37da9a6

File tree

8 files changed

+70
-82
lines changed

8 files changed

+70
-82
lines changed

‎api-reports/2_12.txt‎

Lines changed: 28 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1099,10 +1099,10 @@ CompositionEventInit[JT] var bubbles: js.UndefOr[Boolean]
10991099
CompositionEventInit[JT] var cancelable: js.UndefOr[Boolean]
11001100
CompositionEventInit[JT] var composed: js.UndefOr[Boolean]
11011101
CompositionEventInit[JT] var data: js.UndefOr[String]
1102-
CompositionEventInit[JT] val detail: js.UndefOr[Int]
1102+
CompositionEventInit[JT] var detail: js.UndefOr[Int]
11031103
CompositionEventInit[JT] var locale: js.UndefOr[String]
11041104
CompositionEventInit[JT] var scoped: js.UndefOr[Boolean]
1105-
CompositionEventInit[JT] val view: js.UndefOr[Window]
1105+
CompositionEventInit[JT] var view: js.UndefOr[Window]
11061106
ConcatParams[JT] val algorithmId: BufferSource
11071107
ConcatParams[JT] val hash: HashAlgorithmIdentifier
11081108
ConcatParams[JT] val name: String
@@ -1356,13 +1356,13 @@ DeviceMotionEvent[JC] def stopPropagation(): Unit
13561356
DeviceMotionEvent[JC] def target: EventTarget
13571357
DeviceMotionEvent[JC] def timeStamp: Double
13581358
DeviceMotionEvent[JC] def `type`: String
1359-
DeviceMotionEventInit[JT] val acceleration: js.UndefOr[DeviceAcceleration]
1360-
DeviceMotionEventInit[JT] val accelerationIncludingGravity: js.UndefOr[DeviceAcceleration]
1359+
DeviceMotionEventInit[JT] var acceleration: js.UndefOr[DeviceAcceleration]
1360+
DeviceMotionEventInit[JT] var accelerationIncludingGravity: js.UndefOr[DeviceAcceleration]
13611361
DeviceMotionEventInit[JT] var bubbles: js.UndefOr[Boolean]
13621362
DeviceMotionEventInit[JT] var cancelable: js.UndefOr[Boolean]
13631363
DeviceMotionEventInit[JT] var composed: js.UndefOr[Boolean]
1364-
DeviceMotionEventInit[JT] val interval: js.UndefOr[Double]
1365-
DeviceMotionEventInit[JT] val rotationRate: js.UndefOr[DeviceRotationRate]
1364+
DeviceMotionEventInit[JT] var interval: js.UndefOr[Double]
1365+
DeviceMotionEventInit[JT] var rotationRate: js.UndefOr[DeviceRotationRate]
13661366
DeviceMotionEventInit[JT] var scoped: js.UndefOr[Boolean]
13671367
DeviceOrientationEvent[JC] val absolute: Boolean
13681368
DeviceOrientationEvent[JC] val alpha: Double
@@ -1972,10 +1972,10 @@ FocusEvent[JC] def view: Window
19721972
FocusEventInit[JT] var bubbles: js.UndefOr[Boolean]
19731973
FocusEventInit[JT] var cancelable: js.UndefOr[Boolean]
19741974
FocusEventInit[JT] var composed: js.UndefOr[Boolean]
1975-
FocusEventInit[JT] val detail: js.UndefOr[Int]
1976-
FocusEventInit[JT] val relatedTarget: js.UndefOr[EventTarget]
1975+
FocusEventInit[JT] var detail: js.UndefOr[Int]
1976+
FocusEventInit[JT] var relatedTarget: js.UndefOr[EventTarget]
19771977
FocusEventInit[JT] var scoped: js.UndefOr[Boolean]
1978-
FocusEventInit[JT] val view: js.UndefOr[Window]
1978+
FocusEventInit[JT] var view: js.UndefOr[Window]
19791979
FormData[JC] def append(name: js.Any, value: js.Any, blobName: String?): Unit
19801980
FormData[JO]
19811981
FrameType[JT]
@@ -14682,7 +14682,7 @@ KeyboardEventInit[JT] var cancelable: js.UndefOr[Boolean]
1468214682
KeyboardEventInit[JT] var charCode: js.UndefOr[Int]
1468314683
KeyboardEventInit[JT] var composed: js.UndefOr[Boolean]
1468414684
KeyboardEventInit[JT] var ctrlKey: js.UndefOr[Boolean]
14685-
KeyboardEventInit[JT] val detail: js.UndefOr[Int]
14685+
KeyboardEventInit[JT] var detail: js.UndefOr[Int]
1468614686
KeyboardEventInit[JT] var key: js.UndefOr[String]
1468714687
KeyboardEventInit[JT] var keyCode: js.UndefOr[Int]
1468814688
KeyboardEventInit[JT] var locale: js.UndefOr[String]
@@ -14691,7 +14691,7 @@ KeyboardEventInit[JT] var metaKey: js.UndefOr[Boolean]
1469114691
KeyboardEventInit[JT] var repeat: js.UndefOr[Boolean]
1469214692
KeyboardEventInit[JT] var scoped: js.UndefOr[Boolean]
1469314693
KeyboardEventInit[JT] var shiftKey: js.UndefOr[Boolean]
14694-
KeyboardEventInit[JT] val view: js.UndefOr[Window]
14694+
KeyboardEventInit[JT] var view: js.UndefOr[Window]
1469514695
LinkStyle[JT] def sheet: StyleSheet
1469614696
Location[JT] def assign(url: String): Unit
1469714697
Location[JT] var hash: String
@@ -15017,7 +15017,7 @@ MouseEventInit[JT] var clientX: js.UndefOr[Double]
1501715017
MouseEventInit[JT] var clientY: js.UndefOr[Double]
1501815018
MouseEventInit[JT] var composed: js.UndefOr[Boolean]
1501915019
MouseEventInit[JT] var ctrlKey: js.UndefOr[Boolean]
15020-
MouseEventInit[JT] val detail: js.UndefOr[Int]
15020+
MouseEventInit[JT] var detail: js.UndefOr[Int]
1502115021
MouseEventInit[JT] var metaKey: js.UndefOr[Boolean]
1502215022
MouseEventInit[JT] var pageX: js.UndefOr[Double]
1502315023
MouseEventInit[JT] var pageY: js.UndefOr[Double]
@@ -15026,7 +15026,7 @@ MouseEventInit[JT] var scoped: js.UndefOr[Boolean]
1502615026
MouseEventInit[JT] var screenX: js.UndefOr[Double]
1502715027
MouseEventInit[JT] var screenY: js.UndefOr[Double]
1502815028
MouseEventInit[JT] var shiftKey: js.UndefOr[Boolean]
15029-
MouseEventInit[JT] val view: js.UndefOr[Window]
15029+
MouseEventInit[JT] var view: js.UndefOr[Window]
1503015030
MutationObserver[JC] def disconnect(): Unit
1503115031
MutationObserver[JC] def observe(target: Node, options: MutationObserverInit): Unit
1503215032
MutationObserver[JC] def takeRecords(): js.Array[MutationRecord]
@@ -15480,7 +15480,7 @@ PointerEventInit[JT] var clientX: js.UndefOr[Double]
1548015480
PointerEventInit[JT] var clientY: js.UndefOr[Double]
1548115481
PointerEventInit[JT] var composed: js.UndefOr[Boolean]
1548215482
PointerEventInit[JT] var ctrlKey: js.UndefOr[Boolean]
15483-
PointerEventInit[JT] val detail: js.UndefOr[Int]
15483+
PointerEventInit[JT] var detail: js.UndefOr[Int]
1548415484
PointerEventInit[JT] var height: js.UndefOr[Double]
1548515485
PointerEventInit[JT] var isPrimary: js.UndefOr[Boolean]
1548615486
PointerEventInit[JT] var metaKey: js.UndefOr[Boolean]
@@ -15498,7 +15498,7 @@ PointerEventInit[JT] var tangentialPressure: js.UndefOr[Double]
1549815498
PointerEventInit[JT] var tiltX: js.UndefOr[Double]
1549915499
PointerEventInit[JT] var tiltY: js.UndefOr[Double]
1550015500
PointerEventInit[JT] var twist: js.UndefOr[Double]
15501-
PointerEventInit[JT] val view: js.UndefOr[Window]
15501+
PointerEventInit[JT] var view: js.UndefOr[Window]
1550215502
PointerEventInit[JT] var width: js.UndefOr[Double]
1550315503
PopStateEvent[JT] def bubbles: Boolean
1550415504
PopStateEvent[JT] def cancelBubble: Boolean
@@ -15963,9 +15963,9 @@ Response[JC] def `type`: ResponseType
1596315963
Response[JC] def url: String
1596415964
Response[JO] def error(): Response
1596515965
Response[JO] def redirect(url: String, status: Int?): Response
15966-
ResponseInit[JT] var headers: HeadersInit
15967-
ResponseInit[JT] var status: Int
15968-
ResponseInit[JT] var statusText: ByteString
15966+
ResponseInit[JT] var headers: js.UndefOr[HeadersInit]
15967+
ResponseInit[JT] var status: js.UndefOr[Int]
15968+
ResponseInit[JT] var statusText: js.UndefOr[ByteString]
1596915969
ResponseType[JT]
1597015970
ResponseType[SO] val basic: ResponseType
1597115971
ResponseType[SO] val cors: ResponseType
@@ -23926,13 +23926,13 @@ SVGZoomAndPan[JT] var zoomAndPan: Int
2392623926
SVGZoomEventInit[JT] var bubbles: js.UndefOr[Boolean]
2392723927
SVGZoomEventInit[JT] var cancelable: js.UndefOr[Boolean]
2392823928
SVGZoomEventInit[JT] var composed: js.UndefOr[Boolean]
23929-
SVGZoomEventInit[JT] val detail: js.UndefOr[Int]
23929+
SVGZoomEventInit[JT] var detail: js.UndefOr[Int]
2393023930
SVGZoomEventInit[JT] var newScale: js.UndefOr[Double]
2393123931
SVGZoomEventInit[JT] var newTranslate: js.UndefOr[SVGPoint]
2393223932
SVGZoomEventInit[JT] var previousScale: js.UndefOr[Double]
2393323933
SVGZoomEventInit[JT] var previousTranslate: js.UndefOr[SVGPoint]
2393423934
SVGZoomEventInit[JT] var scoped: js.UndefOr[Boolean]
23935-
SVGZoomEventInit[JT] val view: js.UndefOr[Window]
23935+
SVGZoomEventInit[JT] var view: js.UndefOr[Window]
2393623936
SVGZoomEventInit[JT] var zoomRectScreen: js.UndefOr[SVGRect]
2393723937
Screen[JC] def availHeight: Double
2393823938
Screen[JC] def availWidth: Double
@@ -24283,11 +24283,11 @@ TextEventInit[JT] var bubbles: js.UndefOr[Boolean]
2428324283
TextEventInit[JT] var cancelable: js.UndefOr[Boolean]
2428424284
TextEventInit[JT] var composed: js.UndefOr[Boolean]
2428524285
TextEventInit[JT] var data: js.UndefOr[String]
24286-
TextEventInit[JT] val detail: js.UndefOr[Int]
24286+
TextEventInit[JT] var detail: js.UndefOr[Int]
2428724287
TextEventInit[JT] var inputMethod: js.UndefOr[Int]
2428824288
TextEventInit[JT] var locale: js.UndefOr[String]
2428924289
TextEventInit[JT] var scoped: js.UndefOr[Boolean]
24290-
TextEventInit[JT] val view: js.UndefOr[Window]
24290+
TextEventInit[JT] var view: js.UndefOr[Window]
2429124291
TextMetrics[JC] var width: Double
2429224292
TextTrack[JO] var DISABLED: Int
2429324293
TextTrack[JO] var ERROR: Int
@@ -24393,13 +24393,13 @@ TouchEventInit[JT] var cancelable: js.UndefOr[Boolean]
2439324393
TouchEventInit[JT] var changedTouches: js.UndefOr[TouchList]
2439424394
TouchEventInit[JT] var composed: js.UndefOr[Boolean]
2439524395
TouchEventInit[JT] var ctrlKey: js.UndefOr[Boolean]
24396-
TouchEventInit[JT] val detail: js.UndefOr[Int]
24396+
TouchEventInit[JT] var detail: js.UndefOr[Int]
2439724397
TouchEventInit[JT] var metaKey: js.UndefOr[Boolean]
2439824398
TouchEventInit[JT] var scoped: js.UndefOr[Boolean]
2439924399
TouchEventInit[JT] var shiftKey: js.UndefOr[Boolean]
2440024400
TouchEventInit[JT] var targetTouches: js.UndefOr[TouchList]
2440124401
TouchEventInit[JT] var touches: js.UndefOr[TouchList]
24402-
TouchEventInit[JT] val view: js.UndefOr[Window]
24402+
TouchEventInit[JT] var view: js.UndefOr[Window]
2440324403
TouchList[JT] @JSBracketAccess def apply(index: Int): T
2440424404
TouchList[JT] def item(index: Int): Touch
2440524405
TouchList[JT] def length: Int
@@ -24464,9 +24464,9 @@ UIEvent[JC] def view: Window
2446424464
UIEventInit[JT] var bubbles: js.UndefOr[Boolean]
2446524465
UIEventInit[JT] var cancelable: js.UndefOr[Boolean]
2446624466
UIEventInit[JT] var composed: js.UndefOr[Boolean]
24467-
UIEventInit[JT] val detail: js.UndefOr[Int]
24467+
UIEventInit[JT] var detail: js.UndefOr[Int]
2446824468
UIEventInit[JT] var scoped: js.UndefOr[Boolean]
24469-
UIEventInit[JT] val view: js.UndefOr[Window]
24469+
UIEventInit[JT] var view: js.UndefOr[Window]
2447024470
URL[JC] var hash: String
2447124471
URL[JC] var host: String
2447224472
URL[JC] var hostname: String
@@ -25095,7 +25095,7 @@ WheelEventInit[JT] var deltaMode: js.UndefOr[Int]
2509525095
WheelEventInit[JT] var deltaX: js.UndefOr[Double]
2509625096
WheelEventInit[JT] var deltaY: js.UndefOr[Double]
2509725097
WheelEventInit[JT] var deltaZ: js.UndefOr[Double]
25098-
WheelEventInit[JT] val detail: js.UndefOr[Int]
25098+
WheelEventInit[JT] var detail: js.UndefOr[Int]
2509925099
WheelEventInit[JT] var metaKey: js.UndefOr[Boolean]
2510025100
WheelEventInit[JT] var pageX: js.UndefOr[Double]
2510125101
WheelEventInit[JT] var pageY: js.UndefOr[Double]
@@ -25104,7 +25104,7 @@ WheelEventInit[JT] var scoped: js.UndefOr[Boolean]
2510425104
WheelEventInit[JT] var screenX: js.UndefOr[Double]
2510525105
WheelEventInit[JT] var screenY: js.UndefOr[Double]
2510625106
WheelEventInit[JT] var shiftKey: js.UndefOr[Boolean]
25107-
WheelEventInit[JT] val view: js.UndefOr[Window]
25107+
WheelEventInit[JT] var view: js.UndefOr[Window]
2510825108
Window[JC] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
2510925109
Window[JC] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
2511025110
Window[JC] def alert(): Unit
@@ -25648,14 +25648,8 @@ experimental/package[SO] lazy val ResponseType: dom.ResponseType.type (@depreca
2564825648
experimental/package[SO] lazy val WriteableState: dom.WriteableState.type (@deprecated in 2.0.0)
2564925649
experimental/package[SO] def apply(_status: Int = 200, _statusText: ByteString = "OK", _headers: HeadersInit = js.Dictionary[String]()): ResponseInit
2565025650
experimental/package[SO] @js.native @JSGlobal("fetch") def fetch(info: RequestInfo, init: RequestInit = null): js.Promise[Response]
25651-
experimental/package[SO] var headers = _headers
25652-
experimental/package[SO] var status = _status
25653-
experimental/package[SO] var statusText = _statusText
2565425651
experimental/package.Fetch[SO] @js.native @JSGlobal("fetch") def fetch(info: RequestInfo, init: RequestInit = null): js.Promise[Response] (@deprecated in 2.0.0)
2565525652
experimental/package.ResponseInit[SO] def apply(_status: Int = 200, _statusText: ByteString = "OK", _headers: HeadersInit = js.Dictionary[String]()): ResponseInit (@deprecated in 2.0.0)
25656-
experimental/package.ResponseInit[SO] var headers = _headers (@deprecated in 2.0.0)
25657-
experimental/package.ResponseInit[SO] var status = _status (@deprecated in 2.0.0)
25658-
experimental/package.ResponseInit[SO] var statusText = _statusText (@deprecated in 2.0.0)
2565925653
experimental/permissions/package[SO] type PermissionDescriptor = dom.PermissionDescriptor (@deprecated in 2.0.0)
2566025654
experimental/permissions/package[SO] type PermissionName = dom.PermissionName (@deprecated in 2.0.0)
2566125655
experimental/permissions/package[SO] type PermissionState = dom.PermissionState (@deprecated in 2.0.0)

0 commit comments

Comments
 (0)