refactor: make Path a sequence of InvocationCoordinate instead of Any #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #221 +/- ##
=========================================
Coverage ? 61.91%
=========================================
Files ? 58
Lines ? 730
Branches ? 59
=========================================
Hits ? 452
Misses ? 278
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tassiluca
force-pushed
the
refactor/path
branch
from
4831867 to
42e389f
Compare
nicolasfara
requested changes
Dec 26, 2025
| import org.scalatest.matchers.should | ||
|
|
||
| class ExportTest extends AnyFlatSpecLike, should.Matchers: | ||
| private given Conversion[String, InvocationCoordinate] = key => InvocationCoordinate(key, invocationCount = 0) |
Contributor
There was a problem hiding this comment.
Can this implicit be refactored into a single implementation somewhere? It is used twice in the tests.
Does it make sense?
nicolasfara
force-pushed
the
refactor/path
branch
4 times, most recently
from
5079244 to
b6f58f2
Compare
nicolasfara
force-pushed
the
refactor/path
branch
2 times, most recently
from
e53ebd1 to
648e10e
Compare
nicolasfara
force-pushed
the
refactor/path
branch
from
648e10e to
b9f2dab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.