Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test project configs for viaIR detection in overrides #856

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

cgewecke
Copy link
Member

@cgewecke cgewecke commented Feb 9, 2024

viaIR was at the wrong level in the hardhat.config.js for these tests. (Codecov caught this - should tick up slightly)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f007c7) 95.77% compared to head (ad90e26) 95.87%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #856      +/-   ##
==========================================
+ Coverage   95.77%   95.87%   +0.09%     
==========================================
  Files          19       19              
  Lines        1017     1017              
==========================================
+ Hits          974      975       +1     
+ Misses         43       42       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgewecke cgewecke merged commit 01ab173 into master Feb 9, 2024
3 checks passed
@cgewecke cgewecke deleted the fix-viaIR-overrides-test branch February 9, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants