Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use internal visibility for fn level hash method defs #660

Merged
merged 2 commits into from
Aug 28, 2021

Conversation

cgewecke
Copy link
Member

@cgewecke cgewecke commented Aug 28, 2021

#651, #649

Excludes contract level instrumentation from the contract's public interface.

This doubles the line hits for some reason...nbd - we already have this problem on the beta with the boolean hash methods.

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2021

Codecov Report

Merging #660 (d09b0b7) into master (4c2410d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #660   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files          22       22           
  Lines         991      991           
=======================================
  Hits          978      978           
  Misses         13       13           
Impacted Files Coverage Δ
lib/injector.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c2410d...d09b0b7. Read the comment docs.

@cgewecke cgewecke marked this pull request as ready for review August 28, 2021 16:02
@cgewecke cgewecke merged commit 022d7d8 into master Aug 28, 2021
@cgewecke cgewecke deleted the chris/fix-instrumenter-visibility branch August 28, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants