Stop reporting assert statements as branches #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #556 +/- ##
=======================================
Coverage 99.27% 99.27%
=======================================
Files 20 20
Lines 824 824
=======================================
Hits 818 818
Misses 6 6
Continue to review full report at Codecov.
|
bingen
added a commit
to liquity/dev
that referenced
this pull request
Jan 13, 2021
It was an artifical test to cover the else branch of an assert, but asserts shouldn’t count for covergage: sc-forks/solidity-coverage#556
This was referenced May 27, 2021
This was referenced Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#269
As Nicholas Venturo notes in #269: "assert shouldn't ever fail unless the code is buggy" and it should be impossible to write test cases for both branches.
I proposed making this an option a long time ago but there does not seem to be a reason to use
assertoutside Solidity's SMTChecker or similar. Treating these as a branches discourages their use.(See comments in 269)