feat: Add Targeting #266
Closed
feat: Add Targeting #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public static final String PROP_AD_SIZE = "adSize"; | ||
| public static final String PROP_VALID_AD_SIZES = "validAdSizes"; | ||
| public static final String PROP_AD_UNIT_ID = "adUnitID"; | ||
| public static final String PROP_BANNER_TARGETING = "targeting" |
added 2 commits
March 8, 2018 14:27
Collaborator
|
Thanks for your PR, but custom string parsing is not something we want for this. Please see #166 and add any comments or suggestions you have for this feature there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add targeting for request DFP