From 9150e58228ba904c6ee228f34e961f4490495fcd Mon Sep 17 00:00:00 2001 From: Simon Berz Date: Fri, 18 Aug 2023 10:10:44 +0200 Subject: [PATCH] fix!(mongodb): remove broken type export `V4Connection` The type `V4Connection` re-introduced in #1170 is missing any type definitions or imports for `Document`, breaking the build with Typescript strict mode. `V4Connection` in `types.ts` is not referenced anywhere (the type definition in `internal-types.ts` is used. So lets just drop this type definition. BREAKING CHANGE: removes the broken exported type `V4Connection`. Fixes #1639 --- .../src/types.ts | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/plugins/node/opentelemetry-instrumentation-mongodb/src/types.ts b/plugins/node/opentelemetry-instrumentation-mongodb/src/types.ts index e0389de007..e2da034215 100644 --- a/plugins/node/opentelemetry-instrumentation-mongodb/src/types.ts +++ b/plugins/node/opentelemetry-instrumentation-mongodb/src/types.ts @@ -69,14 +69,3 @@ export enum MongodbCommandType { COUNT = 'count', UNKNOWN = 'unknown', } - -// https://github.com/mongodb/node-mongodb-native/blob/v4.2.2/src/cmap/connection.ts -export type V4Connection = { - id: number | ''; - command( - ns: any, - cmd: Document, - options: undefined | unknown, - callback: any - ): void; -};