Skip to content

Commit d17362e

Browse files
authored
Fix urlpatterns use Sequence instead of List (#19)
Use `Sequence` instead of `List` in `apply_suffix_patterns` and `format_suffix_patterns`. This thread, python/mypy#3351 (comment), explains why `List`, which is invariant, isn't suitable here
1 parent 81b0175 commit d17362e

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

rest_framework-stubs/urlpatterns.pyi

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
1-
from typing import List, Optional, Pattern, Union
1+
from typing import List, Optional, Pattern, Sequence, Union
22

33
from django.urls.resolvers import RoutePattern, URLPattern, URLResolver
44

55
def apply_suffix_patterns(
6-
urlpatterns: List[Union[URLResolver, RoutePattern, URLPattern, Pattern[str]]],
6+
urlpatterns: Sequence[Union[URLResolver, RoutePattern, URLPattern, Pattern[str]]],
77
suffix_pattern: Union[str, Pattern[str]],
88
suffix_required: bool,
99
suffix_route: Optional[str] = ...,
1010
) -> List[URLPattern]: ...
1111
def format_suffix_patterns(
12-
urlpatterns: List[Union[URLResolver, RoutePattern, URLPattern, Pattern[str]]],
12+
urlpatterns: Sequence[Union[URLResolver, RoutePattern, URLPattern, Pattern[str]]],
1313
suffix_required: bool = ...,
1414
allowed: Optional[List[Union[URLPattern, Pattern[str], str]]] = ...,
1515
) -> List[URLPattern]: ...

0 commit comments

Comments
 (0)