Factor out updateMemoryViews

Also, enable HEAPXX exports to be specified in EXPORT_RUNTIME_METHODS.

For not we continue to export all them this under the regular runtime,
unless STRICT mode is used.

Replaces emscripten-core#21407

Author: sbc100

ChangeLog.md

@@ -21,6 +21,10 @@ See docs/process.md for more on how version tagging works.
 3.1.55 (in development)
 -----------------------
 - Update sdl2-mixer port from 2.6.0 to 2.8.0
+- In `STRICT` mode the `HEAPXX` symbols (such as `HEAP8` and `HEAP32`) are now
+  only exported on demand.  This means that they must be added to
+  `EXPORTED_RUNTIME_METHODS` for them to appear on the `Module` object.  For
+  now, this only effects users of `STRICT` mode.
 
 3.1.54 - 02/15/24
 -----------------

src/modules.js

@@ -349,6 +349,10 @@ function exportRuntime() {
   // being exported. how we show the message depends on whether it's
   // a function (almost all of them) or a number.
   function maybeExport(name) {
+    // HEAP objects are exported separetly in updateMemoryViews
+    if (name.startsWith('HEAP')) {
+      return;
+    }
     // if requested to be exported, export it
     if (EXPORTED_RUNTIME_METHODS_SET.has(name)) {
       let exported = name;
@@ -385,6 +389,13 @@ function exportRuntime() {
     'abort',
     'wasmMemory',
     'wasmExports',
+    'HEAPF32',
+    'HEAPF64',
+    'HEAP_DATA_VIEW',
+    'HEAP8',  'HEAPU8',
+    'HEAP16', 'HEAPU16',
+    'HEAP32', 'HEAPU32',
+    'HEAP64', 'HEAPU64',
   ];
 
   // These are actually native wasm functions these days but we allow exporting

src/preamble.js

@@ -138,24 +138,7 @@ var HEAP,
 var HEAP_DATA_VIEW;
 #endif
 
-function updateMemoryViews() {
-  var b = wasmMemory.buffer;
-#if SUPPORT_BIG_ENDIAN
-  Module['HEAP_DATA_VIEW'] = HEAP_DATA_VIEW = new DataView(b);
-#endif
-  Module['HEAP8'] = HEAP8 = new Int8Array(b);
-  Module['HEAP16'] = HEAP16 = new Int16Array(b);
-  Module['HEAPU8'] = HEAPU8 = new Uint8Array(b);
-  Module['HEAPU16'] = HEAPU16 = new Uint16Array(b);
-  Module['HEAP32'] = HEAP32 = new Int32Array(b);
-  Module['HEAPU32'] = HEAPU32 = new Uint32Array(b);
-  Module['HEAPF32'] = HEAPF32 = new Float32Array(b);
-  Module['HEAPF64'] = HEAPF64 = new Float64Array(b);
-#if WASM_BIGINT
-  Module['HEAP64'] = HEAP64 = new BigInt64Array(b);
-  Module['HEAPU64'] = HEAPU64 = new BigUint64Array(b);
-#endif
-}
+#include "runtime_shared.js"
 
 #if ASSERTIONS
 assert(!Module['STACK_SIZE'], 'STACK_SIZE can no longer be set at runtime.  Use -sSTACK_SIZE at link time')

src/preamble_minimal.js

@@ -4,17 +4,6 @@
  * SPDX-License-Identifier: MIT
  */
 
-{{{
-  // Helper function to export a symbol on the module object
-  // if requested.
-  globalThis.maybeExport = (x) => MODULARIZE && EXPORT_ALL ? `Module['${x}'] = ` : '';
-  // Export to the AudioWorkletGlobalScope the needed variables to access
-  // the heap. AudioWorkletGlobalScope is unable to access global JS vars
-  // in the compiled main JS file.
-  globalThis.maybeExportIfAudioWorklet = (x) => (MODULARIZE && EXPORT_ALL) || AUDIO_WORKLET ? `Module['${x}'] = ` : '';
-  null;
-}}}
-
 #if SAFE_HEAP
 #include "runtime_safe_heap.js"
 #endif
@@ -65,27 +54,7 @@ var HEAP8, HEAP16, HEAP32, HEAPU8, HEAPU16, HEAPU32, HEAPF32, HEAPF64,
 #endif
   wasmMemory;
 
-function updateMemoryViews() {
-  var b = wasmMemory.buffer;
-#if ASSERTIONS && SHARED_MEMORY
-  assert(b instanceof SharedArrayBuffer, 'requested a shared WebAssembly.Memory but the returned buffer is not a SharedArrayBuffer, indicating that while the browser has SharedArrayBuffer it does not have WebAssembly threads support - you may need to set a flag');
-#endif
-#if SUPPORT_BIG_ENDIAN
-  {{{ maybeExport('HEAP_DATA_VIEW') }}} HEAP_DATA_VIEW = new DataView(b);
-#endif
-  {{{ maybeExport('HEAP8') }}} HEAP8 = new Int8Array(b);
-  {{{ maybeExport('HEAP16') }}} HEAP16 = new Int16Array(b);
-  {{{ maybeExport('HEAPU8') }}} HEAPU8 = new Uint8Array(b);
-  {{{ maybeExport('HEAPU16') }}} HEAPU16 = new Uint16Array(b);
-  {{{ maybeExport('HEAP32') }}} HEAP32 = new Int32Array(b);
-  {{{ maybeExportIfAudioWorklet('HEAPU32') }}} HEAPU32 = new Uint32Array(b);
-  {{{ maybeExportIfAudioWorklet('HEAPF32') }}} HEAPF32 = new Float32Array(b);
-  {{{ maybeExport('HEAPF64') }}} HEAPF64 = new Float64Array(b);
-#if WASM_BIGINT
-  {{{ maybeExport('HEAP64') }}} HEAP64 = new BigInt64Array(b);
-  {{{ maybeExport('HEAPU64') }}} HEAPU64 = new BigUint64Array(b);
-#endif
-}
+#include "runtime_shared.js"
 
 #if IMPORTED_MEMORY
 #if PTHREADS
@@ -116,6 +85,10 @@ else {
 #endif // MODULARIZE
 #endif // PTHREADS
 
+#if ASSERTIONS && SHARED_MEMORY
+assert(wasmMemory.buffer instanceof SharedArrayBuffer, 'requested a shared WebAssembly.Memory but the returned buffer is not a SharedArrayBuffer, indicating that while the browser has SharedArrayBuffer it does not have WebAssembly threads support - you may need to set a flag');
+#endif
+
 updateMemoryViews();
 #endif // IMPORTED_MEMORY
 

src/runtime_init_memory.js

@@ -14,7 +14,7 @@
 #if ASSERTIONS
 assert(INITIAL_MEMORY >= {{{STACK_SIZE}}}, 'INITIAL_MEMORY should be larger than STACK_SIZE, was ' + INITIAL_MEMORY + '! (STACK_SIZE=' + {{{STACK_SIZE}}} + ')');
 #endif
-  
+
 // check for full engine support (use string 'subarray' to avoid closure compiler confusion)
 
 #if PTHREADS

src/runtime_shared.js

@@ -0,0 +1,48 @@
+/**
+ * @license
+ * Copyright 2024 The Emscripten Authors
+ * SPDX-License-Identifier: MIT
+ */
+
+{{{
+  // Helper function to export a heap symbol on the module object,
+  // if requested.
+  globalThis.maybeExportHeap = (x) => {
+    // For now, we export all heap object when not building with MINIMAL_RUNTIME
+    let shouldExport = !MINIMAL_RUNTIME && !STRICT;
+    if (!shouldExport) {
+      if (MODULARIZE && EXPORT_ALL) {
+        shouldExport = true;
+      } else if (AUDIO_WORKLET && (x == 'HEAP32' || x == 'HEAPU32')) {
+        // Export to the AudioWorkletGlobalScope the needed variables to access
+        // the heap. AudioWorkletGlobalScope is unable to access global JS vars
+        // in the compiled main JS file.
+        shouldExport = true;
+      } else if (EXPORTED_RUNTIME_METHODS.includes(x)) {
+        shouldExport = true;
+      }
+    }
+
+    return shouldExport ? `Module['${x}'] = ` : '';
+  };
+  null;
+}}}
+
+function updateMemoryViews() {
+  var b = wasmMemory.buffer;
+#if SUPPORT_BIG_ENDIAN
+  {{{ maybeExport('HEAP_DATA_VIEW') }}} HEAP_DATA_VIEW = new DataView(b);
+#endif
+  {{{ maybeExportHeap('HEAP8')   }}}HEAP8 = new Int8Array(b);
+  {{{ maybeExportHeap('HEAP16')  }}}HEAP16 = new Int16Array(b);
+  {{{ maybeExportHeap('HEAPU8')  }}}HEAPU8 = new Uint8Array(b);
+  {{{ maybeExportHeap('HEAPU16') }}}HEAPU16 = new Uint16Array(b);
+  {{{ maybeExportHeap('HEAP32')  }}}HEAP32 = new Int32Array(b);
+  {{{ maybeExportHeap('HEAPU32') }}}HEAPU32 = new Uint32Array(b);
+  {{{ maybeExportHeap('HEAPF32') }}}HEAPF32 = new Float32Array(b);
+  {{{ maybeExportHeap('HEAPF64') }}}HEAPF64 = new Float64Array(b);
+#if WASM_BIGINT
+  {{{ maybeExportHeap('HEAP64')  }}}HEAP64 = new BigInt64Array(b);
+  {{{ maybeExportHeap('HEAPU64') }}}HEAPU64 = new BigUint64Array(b);
+#endif
+}

test/other/metadce/test_metadce_hello_O0.gzsize

@@ -1 +1 @@
-8356
+8391

test/other/metadce/test_metadce_hello_O0.jssize

@@ -1 +1 @@
-22913
+23002

test/other/metadce/test_metadce_minimal_64.gzsize

@@ -1 +1 @@
-1725
+1685

test/other/metadce/test_metadce_minimal_64.jssize

@@ -1 +1 @@
-3635
+3541