Skip to content

Commit bcef271

Browse files
committed
Refactor test_text_messages to use existing fixtures
1 parent bf73382 commit bcef271

File tree

1 file changed

+22
-22
lines changed

1 file changed

+22
-22
lines changed

tests/test_text_messages.py

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,97 +1,97 @@
1-
from utils import session, server
1+
from utils import session, threaded_server
22

33

44
def test_text_message_of_length_1(session):
5-
client, server = session
5+
conn, server = session
66
server.send_message_to_all('$')
7-
assert client.recv() == '$'
7+
assert conn.recv() == '$'
88

99

1010
def test_text_message_of_length_125B(session):
11-
client, server = session
11+
conn, server = session
1212
msg = 'abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz'\
1313
'abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz'\
1414
'abcdefghijklmnopqr125'
1515
server.send_message_to_all(msg)
16-
assert client.recv() == msg
16+
assert conn.recv() == msg
1717

1818

1919
def test_text_message_of_length_126B(session):
20-
client, server = session
20+
conn, server = session
2121
msg = 'abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz'\
2222
'abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz'\
2323
'abcdefghijklmnopqrs126'
2424
server.send_message_to_all(msg)
25-
assert client.recv() == msg
25+
assert conn.recv() == msg
2626

2727

2828
def test_text_message_of_length_127B(session):
29-
client, server = session
29+
conn, server = session
3030
msg = 'abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz'\
3131
'abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz'\
3232
'abcdefghijklmnopqrst127'
3333
server.send_message_to_all(msg)
34-
assert client.recv() == msg
34+
assert conn.recv() == msg
3535

3636

3737
def test_text_message_of_length_208B(session):
38-
client, server = session
38+
conn, server = session
3939
msg = 'abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz'\
4040
'abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz'\
4141
'abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz'\
4242
'abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvw208'
4343
server.send_message_to_all(msg)
44-
assert client.recv() == msg
44+
assert conn.recv() == msg
4545

4646

4747
def test_text_message_of_length_1251B(session):
48-
client, server = session
48+
conn, server = session
4949
msg = ('abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz'\
5050
'abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz'\
5151
'abcdefghijklmnopqr125'*10)+'1'
5252
server.send_message_to_all(msg)
53-
assert client.recv() == msg
53+
assert conn.recv() == msg
5454

5555

5656
def test_text_message_of_length_68KB(session):
57-
client, server = session
57+
conn, server = session
5858
msg = '$'+('a'*67993)+'68000'+'^'
5959
assert len(msg) == 68000
6060
server.send_message_to_all(msg)
61-
assert client.recv() == msg
61+
assert conn.recv() == msg
6262

6363

6464
def test_text_message_of_length_1500KB(session):
6565
""" An enormous message (well beyond 65K) """
66-
client, server = session
66+
conn, server = session
6767
msg = '$'+('a'*1499991)+'1500000'+'^'
6868
assert len(msg) == 1500000
6969
server.send_message_to_all(msg)
70-
assert client.recv() == msg
70+
assert conn.recv() == msg
7171

7272

7373
def test_text_message_with_unicode_characters(session):
74-
client, server = session
74+
conn, server = session
7575
msg = '$äüö^'
7676
server.send_message_to_all(msg)
77-
assert client.recv() == msg
77+
assert conn.recv() == msg
7878

7979

8080
def test_text_message_stress_bursts(session):
81-
""" Scenario: server sends multiple different message to the same client
81+
""" Scenario: server sends multiple different message to the same conn
8282
at once """
8383
from threading import Thread
8484
NUM_THREADS = 100
8585
MESSAGE_LEN = 1000
86-
client, server = session
86+
conn, server = session
8787
messages_received = []
8888

8989
# Threads receing
9090
threads_receiving = []
9191
for i in range(NUM_THREADS):
9292
th = Thread(
9393
target=lambda fn: messages_received.append(fn()),
94-
args=(client.recv,)
94+
args=(conn.recv,)
9595
)
9696
th.daemon = True
9797
threads_receiving.append(th)

0 commit comments

Comments
 (0)