Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the themes part #16

Open
saurabhdaware opened this issue Nov 27, 2019 · 1 comment
Open

Refactor the themes part #16

saurabhdaware opened this issue Nov 27, 2019 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed Needs Discussion Want to discuss this issue and know opinions of others. refactorit

Comments

@saurabhdaware
Copy link
Owner

So currently if someone wants to create a theme they have to go to the card.style.mjs and add a class with name of the theme and set the css variables.

This is super useful and makes things extremely easy to create themes but as we go adding themes we go on increasing the numbers of lines in the JavaScript string (the css is just javascript string). It would be helpful if there is any other way to handle this since I don't want to go on making the response size larger and larger.

@saurabhdaware saurabhdaware added enhancement New feature or request help wanted Extra attention is needed Needs Discussion Want to discuss this issue and know opinions of others. refactorit labels Nov 27, 2019
@saurabhdaware saurabhdaware pinned this issue Nov 27, 2019
@prafulla-codes
Copy link
Contributor

prafulla-codes commented Jan 16, 2020

I don't think there is any other way apart from trying to optimize the way things are styled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed Needs Discussion Want to discuss this issue and know opinions of others. refactorit
Projects
None yet
Development

No branches or pull requests

2 participants