Remove single-threadedness coming from rotation lock #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a single Mutex for all operations (updates and rotation) made all updates single threaded. This change addresses this problem using the RWMutex which treats updates as "reads" since they are allowed to happen concurrently and treats actual rotation as writes. Nothing can update while a rotation happens but multiple updates can happen at the same time while the rotation write lock is not held.
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a single Mutex for all operations (updates and rotation) made all updates single threaded. This change addresses this problem using the RWMutex which treats updates as "reads" since they are allowed to happen concurrently and treats actual rotation as writes. Nothing can update while a rotation happens but multiple updates can happen at the same time while the rotation write lock is not held.
Addresses #5