Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property-sort-order is missing convention-explanation #1140

Open
dariusrosendahl opened this issue Sep 15, 2017 · 2 comments
Open

Property-sort-order is missing convention-explanation #1140

dariusrosendahl opened this issue Sep 15, 2017 · 2 comments
Labels

Comments

@dariusrosendahl
Copy link

What version of Sass Lint are you using?
1.11.1

Please include any relevant parts of your configuration
Using it with vscode

What did you do? Please include the actual source code causing the issue.

What actually happened? Please include any error messages given to you by Sass Lint.
2017-09-15 13_50_30- docs_mainvisual scss castlecss workspace visual studio code - insiders

The errors above not very clear for a lot of users. It would be nice if we could at least see that the order is wront.

If you're using a IDE plugin have you tried the CLI too?
Yes, the output actually says the warning/error is about order:

2017-09-15 13_57_11-eslint report

@DanPurdy
Copy link
Member

DanPurdy commented Sep 25, 2017

@dariusrosendahl I'm assuming you mean the lack of a rule name in the original screenshot/error message?

We include the rule name with all error/warning messages. It looks like the platform you're using to consume sass-lint with is not reporting the rule names to you. I would make an issue with the vscode plugin and ask if they could update their error reporting to show the rule name. As for the rest of the text this is pretty standard for a sort order rule. I believe @glen-84 made the vscode plugin originally over at https://github.com/glen-84/vscode-sass-lint if you'd like to make a suggestion.

@glen-84
Copy link
Contributor

glen-84 commented Nov 19, 2019

This issue can be closed. The rule name (id) was added to the message in v1.0.0 (2017-11-12).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants