JRuby Compatibility #113
Merged
JRuby Compatibility #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
glebm
commented
Nov 17, 2018
glebm
commented
- Test on JRuby.
- Fix sassc-rails not working with jruby 9k #92.
1. Test on JRuby. 2. Fix sass#92.
|
Tried this PR against activeadmin in activeadmin/activeadmin#5504 and it got it green! Thanks so much for the work you've been doing on sassc-rails and libsass, @glebm! |
|
Any reason this hasn't been merged yet? Anything I can help with? |
|
Thanks for merging this and other PRs @bolandrm, everything working for us when using the current master branch 👍. |
|
@bolandrm Can you please release a new version, so that the Rails ecosystem can start moving to libsass? |
|
@glebm 2.1.0 released! |
|
@bolandrm Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.