-
Notifications
You must be signed in to change notification settings - Fork 31
Use gamma 2.40 for display-referred rec2020 #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
47df4e2 to
83307b6
Compare
|
There is a weird ts-jest bug that prevents the test to run on node 20. Otherwise this works fine. Compiled JS code also works fine on node 20 in the js-api-spec test. |
|
@nex3 I fixed other things you pointed out expect the node/typescript/ts-jest compatibility issue. I think one solution is to just compile all test to JS and run plain jest without ts-jest. @Goodwine What was your other workaround for the color.js 6 typescript import issue? I'm curious because at this point maybe that's actually a better solution. |
|
@ntkme I added the following to tsconfig.json: "paths": {
"colorjs.io": "node_modules/colorjs.io/...something.../types.d.ts"
} |
|
Basically I used a freshly cloned repo and tried adding the following under "paths": {
"colorjs.io": "node_modules/colorjs.io/types/src/types.d.ts"
} "paths": {
"colorjs.io": "node_modules/colorjs.io/types/src/index.d.ts"
} "paths": {
"colorjs.io": "node_modules/colorjs.io/types/index.d.ts"
}@Goodwine Am I missing something, or maybe you're running an older version of node, typescript, ts-jest, or jest? |
Bumps [colorjs.io](https://github.com/color-js/color.js) from 0.5.2 to 0.6.1. - [Release notes](https://github.com/color-js/color.js/releases) - [Commits](color-js/color.js@v0.5.2...v0.6.1) --- updated-dependencies: - dependency-name: colorjs.io dependency-version: 0.6.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
Basically I'm keep hitting this color-js/color.js#707 unless I apply the |
864fa45 to
0b66e4d
Compare
0b66e4d to
f5e37c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that color-js/color.js#707 is closed, we don't need this anymore, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not released yet. Depends on whether you want to wait for color.js to cut a release or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine waiting, I don't think the fine details of rec2020 conversions are likely to be a majorly time-sensitive issue for our users.
Closes sass/sass#4185.