Skip to content

Bump protoc_plugin from 21.1.2 to 22.0.1 and protobuf to 4.0.0 #2554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 26, 2025

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 31, 2025

Bumps protoc_plugin from 21.1.2 to 22.0.0.

Release notes

Sourced from protoc_plugin's releases.

package:protoc_plugin v22.0.0

  • Remove PbEventMixin mixin. (#738)
  • Type of repeated fields is now PbList (instead of List), type of map fields is now PbMap (instead of Map). (#903) This change requires protobuf-4.0.0.
  • Generated files now export GeneratedMessageGenericExtensions from the protobuf library. (#503, #907)
  • Generate doc comments for enum types and values, rpc services and methods. (#900, #909)
  • deprecated options in messages, grpc services and methods, and enum types and values are now handled to generate Dart @deprecated annotations. (#900, #908)
  • protoc_plugin and generated files now require Dart 3.3.0. (#953)
  • Fix performance issues when handling documentation comments in protobufs. (#935, #955)
  • Fix grpc methods with names 'call' and 'request' conflicting with other methods in the generated code and causing compile-time errors. (#963, #159)

#738: google/protobuf.dart#738 #903: google/protobuf.dart#903 #503: google/protobuf.dart#503 #907: google/protobuf.dart#907 #900: google/protobuf.dart#900 #909: google/protobuf.dart#909 #908: google/protobuf.dart#908 #953: google/protobuf.dart#953 #935: google/protobuf.dart#935 #955: google/protobuf.dart#955 #963: google/protobuf.dart#963 #159: google/protobuf.dart#159

Commits
  • 3bffe4b Prepare to publish protobuf 4.0.0 and protoc_plugin 22.0.0 (#969)
  • 0bab78d rename -dev pubspec versions to -wip (#968)
  • 7838e44 Prefix grpc method 'call' and 'request' arguments with '$' to avoid shadowing...
  • 125fe9c Bump dart-lang/setup-dart from 1.7.0 to 1.7.1 (#965)
  • fb77c7c Bump actions/cache from 4.2.0 to 4.2.2 (#966)
  • 610943a update the publish workflow; add a post_summaries one (#961)
  • 35a1bd6 update the repo analysis config (#962)
  • d3f9ad1 updates to the gitignore files (#960)
  • 950b6a7 Remove redundant checkNotNull calls from pre-null-safe days (#958)
  • d00f905 Fix slow handling of protobuf comments (#955)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added Dart Issues particular to the pure Dart distribution dependencies Pull requests that update a dependency file labels Mar 31, 2025
@Goodwine
Copy link
Member

I look into this later, but it seems like buf is not compatible with this new version of dart protoc_plugin

@Goodwine
Copy link
Member

@dependabot rebase

I'm not 100% sure how buf-actions works, but I believe it pulls the latest version from the buf repo (unless otherwise configured). The buf repo was updated 3 days ago... so maybe this works now? If not, then I'll take a look tomo

Bumps [protoc_plugin](https://github.com/google/protobuf.dart) from 21.1.2 to 22.0.0.
- [Release notes](https://github.com/google/protobuf.dart/releases)
- [Commits](google/protobuf.dart@protoc_plugin-v21.1.2...protoc_plugin-v22.0.0)

---
updated-dependencies:
- dependency-name: protoc_plugin
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pub/protoc_plugin-22.0.0 branch from 6292949 to 275e7c5 Compare April 24, 2025 23:57
@Goodwine
Copy link
Member

nvm it seems like it uses the same version as as the github plugin. I'll try using the latest version and hopefully that'll work

@Goodwine
Copy link
Member

OK, so it seems the protoc_plugin must use protobuf 4.0.0, but the dependency wasn't updated in the repo. This has been fixed for 22.0.1 - google/protobuf.dart#971

I'll try that change instead :)

@Goodwine Goodwine changed the title Bump protoc_plugin from 21.1.2 to 22.0.0 Bump protoc_plugin from 21.1.2 to 22.0.1 and protobuf to 4.0.0 Apr 26, 2025
@Goodwine
Copy link
Member

yay!

@Goodwine Goodwine merged commit c4b0138 into main Apr 26, 2025
39 checks passed
@Goodwine Goodwine deleted the dependabot/pub/protoc_plugin-22.0.0 branch April 26, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dart Issues particular to the pure Dart distribution dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant