Always limit the repetition of loggers #2391
Merged
+30
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #2390. This is definitely not the correct long-term solution—we only want to limit repetition in the context of a single batch of compilations, and this doesn't always respect `--verbose`—but it's way better to display too few deprecations than too many.
|
I'm planning to land this TBR and cut a release tonight so we don't flood users with deprecation warnings for |
|
@ntkme Since you seem to be around, can you give this and sass/sass-spec#2030 a quick check so they have some approval? |
ntkme
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2390. This is definitely not the correct long-term
solution—we only want to limit repetition in the context of a single
batch of compilations, and this doesn't always respect
--verbose—butit's way better to display too few deprecations than too many.
See sass/sass-spec#2030