-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly drop support for Node 12 #1917
Comments
This also broke support for Node 10 (don't ask) so should definitely have been marked as a major release. |
the supported node version in the |
that's indeed a good idea |
As stated here, we don't consider dropping support for an EOL Node release as a breaking change, as long as we declare this in our package.json (that NPM doesn't use this information for version solving is it's problem, not ours). Node 10 support was dropped back in 1.49.1 (see #1612). We'll drop Node 12 support in #1911. |
We inadvertently broke Node 12 support in 1.59.0 without declaring that we were doing so in our package.json.
1.59.3 temporarily restored support so that NPM isn't downloading invalid versions for those who are still using Node 12, but we should still drop support properly soon, since it's EOL. We may also want to add a check that we're testing against the minimum Node version we declare support for to prevent similar issues in the future.
The text was updated successfully, but these errors were encountered: