Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly drop support for Node 12 #1917

Closed
jathak opened this issue Mar 14, 2023 · 4 comments
Closed

Properly drop support for Node 12 #1917

jathak opened this issue Mar 14, 2023 · 4 comments
Assignees

Comments

@jathak
Copy link
Member

jathak commented Mar 14, 2023

We inadvertently broke Node 12 support in 1.59.0 without declaring that we were doing so in our package.json.

1.59.3 temporarily restored support so that NPM isn't downloading invalid versions for those who are still using Node 12, but we should still drop support properly soon, since it's EOL. We may also want to add a check that we're testing against the minimum Node version we declare support for to prevent similar issues in the future.

@randombitsUK
Copy link

This also broke support for Node 10 (don't ask) so should definitely have been marked as a major release.

@stof
Copy link
Contributor

stof commented Mar 15, 2023

the supported node version in the engine field won't prevent npm from using that version. It will only show a warning. That's why dropping support for node versions is considered a BC break warranting a major version.

@stof
Copy link
Contributor

stof commented Mar 15, 2023

We may also want to add a check that we're testing against the minimum Node version we declare support for to prevent similar issues in the future.

that's indeed a good idea

@jathak
Copy link
Member Author

jathak commented Mar 20, 2023

As stated here, we don't consider dropping support for an EOL Node release as a breaking change, as long as we declare this in our package.json (that NPM doesn't use this information for version solving is it's problem, not ours).

Node 10 support was dropped back in 1.49.1 (see #1612). We'll drop Node 12 support in #1911.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants