Updated client_test to solve lint error #900
Merged
+11
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #900 +/- ##
==========================================
+ Coverage 98.46% 98.86% +0.40%
==========================================
Files 24 26 +2
Lines 1364 1761 +397
==========================================
+ Hits 1343 1741 +398
+ Misses 15 14 -1
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
@sashabaranov Can you please look into this? since without this all other PR's checks are failing due to liniting error |
|
Wow, seems like our linting rules are pretty outdated, created #903 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Latest version of golangci-lint is used in github workflows to check for lint errors. The recent release of golangci-lint introduced additional linting rules, which surfaced a new lint error in client_test.go file. Also linter execinquery is deprecated and linter gomnd is replaced by mnd more info
This PR addresses and resolves that newly reported lint error and removes the deprecated linters.
Describe your solution
PR adds a type assertion to check if the recovered panic value (r) is a string before comparing it to the expected panic message (tt.wantPanic). If r is indeed a string, it verifies that the panic message matches the expected output.If r is not a string, the code now logs a message indicating that the panic value was of an unexpected type.