Feat implement Run APIs #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #560 +/- ##
==========================================
+ Coverage 97.95% 98.22% +0.26%
==========================================
Files 21 22 +1
Lines 1026 1181 +155
==========================================
+ Hits 1005 1160 +155
Misses 15 15
Partials 6 6
|
Open
|
Thank you for the PR! ❤️ We would need to add some integration tests for Assistants API at some point in the future |
sashabaranov
reviewed
Nov 9, 2023
run.go
Outdated
Comment on lines
255
to
262
| func (c *Client) SubmitToolOutputs( | ||
| ctx context.Context, | ||
| threadID string, | ||
| runID string, | ||
| request SubmitToolOutputsRequest) (response Run, err error) { | ||
| urlSuffix := fmt.Sprintf("/threads/%s/runs/%s/submit_tool_outputs", threadID, runID) | ||
| req, err := c.newRequest(ctx, http.MethodPost, c.fullURL(urlSuffix), withBody(request), | ||
| withBetaAssistantV1()) |
There was a problem hiding this comment.
nit: could we please either use single-line or all-in multiple lines, so here it would be
func (c *Client) SubmitToolOutputs(
ctx context.Context,
threadID string,
runID string,
request SubmitToolOutputsRequest,
) (response Run, err error) {
urlSuffix := fmt.Sprintf("/threads/%s/runs/%s/submit_tool_outputs", threadID, runID)
req, err := c.newRequest(
ctx,
http.MethodPost,
c.fullURL(urlSuffix),
withBody(request),
withBetaAssistantV1(),
)
sashabaranov
reviewed
Nov 9, 2023
run.go
Outdated
| limit *int, | ||
| order *string, | ||
| after *string, | ||
| before *string, |
There was a problem hiding this comment.
I wonder if we should pack all these arguments into a struct?
sashabaranov
approved these changes
Nov 9, 2023
maerlyn5
pushed a commit
to prassoai/go-openai
that referenced
this pull request
Nov 22, 2023
* chore: first commit * add apis * chore: add tests * feat add apis * chore: add api and tests * chore: add tests * fix * trigger build * fix * chore: formatting code * chore: add pagination type
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
This branch implements Run APIs
Issue: #533