Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing fields in tool_calls #558

Conversation

henomis
Copy link
Contributor

@henomis henomis commented Nov 9, 2023

Describe the change
There are missing fields in tool_calls object. Following the documentation the chat completion chunk object has the index field also.

Describe your solution
Just added missing fields

Issue: #555

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #558 (7eb4e62) into master (08c167f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #558   +/-   ##
=======================================
  Coverage   97.88%   97.88%           
=======================================
  Files          20       20           
  Lines         991      991           
=======================================
  Hits          970      970           
  Misses         15       15           
  Partials        6        6           
Files Coverage Δ
chat.go 100.00% <ø> (ø)

Copy link
Owner

@sashabaranov sashabaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@sashabaranov sashabaranov merged commit 78862a2 into sashabaranov:master Nov 9, 2023
3 checks passed
maerlyn5 pushed a commit to prassoai/go-openai that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants