Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat Implement threads API #536

Merged
merged 11 commits into from
Nov 9, 2023

Conversation

henomis
Copy link
Contributor

@henomis henomis commented Nov 7, 2023

Describe the change
This branch implements threads API

Describe your solution
Create a new implementation file dedicated to this API

Tests
tests attached in thread_test.go

Issue: #533

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #536 (ef746f3) into master (08c167f) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
+ Coverage   97.88%   97.95%   +0.07%     
==========================================
  Files          20       21       +1     
  Lines         991     1026      +35     
==========================================
+ Hits          970     1005      +35     
  Misses         15       15              
  Partials        6        6              
Files Coverage Δ
thread.go 100.00% <100.00%> (ø)

@urjitbhatia urjitbhatia mentioned this pull request Nov 7, 2023
@henomis
Copy link
Contributor Author

henomis commented Nov 8, 2023

@sashabaranov In this PR I need withBetaAssistantV1() from this PR. So as soon as you merge it I'll be able to complete this one.

@vvatanabe
Copy link
Collaborator

@henomis #545 was merged! 三GO

@henomis henomis marked this pull request as ready for review November 9, 2023 06:48
@henomis
Copy link
Contributor Author

henomis commented Nov 9, 2023

@sashabaranov done! 🔥

@sashabaranov sashabaranov merged commit bc89139 into sashabaranov:master Nov 9, 2023
3 checks passed
maerlyn5 pushed a commit to prassoai/go-openai that referenced this pull request Nov 22, 2023
* feat: implement threads API

* fix

* add tests

* fix

* trigger£

* trigger

* chore: add beta header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants