-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new fields for /v1/images/generation API #530
Support new fields for /v1/images/generation API #530
Conversation
Nice good catch let me update the response object. There is already a lint fix PR #522 thats been opened. |
Codecov Report
@@ Coverage Diff @@
## master #530 +/- ##
=======================================
Coverage 97.85% 97.85%
=======================================
Files 20 20
Lines 978 978
=======================================
Hits 957 957
Misses 15 15
Partials 6 6
|
image.go
Outdated
) | ||
|
||
const ( | ||
CreateImageQualityHD = "hd" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikecutalo
Sometimes you may want to explicitly specify default values in the code. Please add the following as well.
CreateImageQualityStandard = "standard"
https://platform.openai.com/docs/api-reference/images/create#images-create-quality
@mikecutalo Thanks for implementing the new API so quickly! |
Describe the change
Updating the /v1/images/generation api with the new changes announced at devday.
Describe your solution
Simply add new fields to
ImageRequest
&ImageResponseDataInner
as well a bunch of new const's for supported options.Tests
Added more fields to the existing
TestImages
test, as these are later unmarshaled. Although if you would like to see tests that simply assert marshalling I could add some, let me know.Issue: #529