Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Retrieve file content API (#347) #348

Conversation

vvatanabe
Copy link
Collaborator

@vvatanabe vvatanabe commented Jun 9, 2023

This is a pull request for #347, I implemented the Retrieve file content API.
The return value of the GetFileContent function is io.ReadCloser. Because library users flexibility in handling the response.

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #348 (a976077) into master (6830e00) will increase coverage by 1.57%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #348      +/-   ##
==========================================
+ Coverage   93.65%   95.22%   +1.57%     
==========================================
  Files          17       17              
  Lines         646      670      +24     
==========================================
+ Hits          605      638      +33     
+ Misses         30       22       -8     
+ Partials       11       10       -1     
Impacted Files Coverage Δ
chat_stream.go 89.28% <100.00%> (ø)
client.go 94.59% <100.00%> (+2.63%) ⬆️
files.go 95.65% <100.00%> (+13.29%) ⬆️
stream.go 90.62% <100.00%> (ø)

... and 2 files with indirect coverage changes

@vvatanabe vvatanabe marked this pull request as draft June 9, 2023 00:27
@vvatanabe vvatanabe marked this pull request as ready for review June 9, 2023 03:53
@vvatanabe
Copy link
Collaborator Author

@sashabaranov Please check it. Thank you always for reviewing.

Copy link
Owner

@sashabaranov sashabaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this PR! I love the decreased duplication and increased test coverage 🙌🏻

@sashabaranov sashabaranov merged commit a243e73 into sashabaranov:master Jun 11, 2023
@vvatanabe vvatanabe deleted the support-retrieve-file-content-api-347 branch June 11, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants