Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenAI or Azure returns an undefined error message return #283

Merged
merged 6 commits into from
Apr 30, 2023
Merged

Conversation

zjy282
Copy link
Contributor

@zjy282 zjy282 commented Apr 26, 2023

Fix: OpenAI or Azure returns an undefined error message return
#280

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #283 (f23fdfd) into master (2f008f7) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
+ Coverage   92.29%   92.46%   +0.17%     
==========================================
  Files          22       22              
  Lines         662      664       +2     
==========================================
+ Hits          611      614       +3     
+ Misses         37       36       -1     
  Partials       14       14              
Impacted Files Coverage Δ
client.go 88.00% <100.00%> (+0.24%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

#280

Add unit test ErrorResponse nil pointer check
#280

Add unit test ErrorResponse nil pointer check

func TestHandleErrorResp(t *testing.T) {
// var errRes *ErrorResponse
var errRes ErrorResponse
Copy link
Contributor Author

@zjy282 zjy282 Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests for errRes not throwing null pointer exceptions

@sashabaranov
Copy link
Owner

Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants