Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/internal testing #194

Merged
merged 10 commits into from
Mar 24, 2023

Conversation

rexposadas
Copy link
Contributor

See issue: #186

Add helpers in order to reduce boilerplate code in the tests.

To test this PR run the tests: go test ./....

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #194 (bfdc083) into master (2ebb265) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #194   +/-   ##
=======================================
  Coverage   71.84%   71.84%           
=======================================
  Files          21       21           
  Lines         579      579           
=======================================
  Hits          416      416           
  Misses        124      124           
  Partials       39       39           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sashabaranov
Copy link
Owner

Excellent work, thank you so much!

QQ: do we even need to factor checks into a subpackage? Single import of test and calls like test.NoError(t, err, "ListEngines error") seems like a nice API, what do you think?

@rexposadas
Copy link
Contributor Author

Excellent work, thank you so much!

QQ: do we even need to factor checks into a subpackage? Single import of test and calls like test.NoError(t, err, "ListEngines error") seems like a nice API, what do you think?

Good question. I didn't want the name to be too close with the std testing package.

But if that worry is unwarranted, I can refactor it. I'm fine either way.

@sashabaranov
Copy link
Owner

Got it, makes sense!

@sashabaranov sashabaranov merged commit 8e3a046 into sashabaranov:master Mar 24, 2023
@rexposadas rexposadas deleted the refactor/internal-testing branch March 24, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants