-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stream return EOF when openai return error #184
fix: stream return EOF when openai return error #184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! 🔥 Looks good overall, but there are a couple of comments. Would you be able to fix those?
Codecov Report
@@ Coverage Diff @@
## master #184 +/- ##
==========================================
+ Coverage 70.65% 71.12% +0.47%
==========================================
Files 18 21 +3
Lines 535 568 +33
==========================================
+ Hits 378 404 +26
- Misses 121 125 +4
- Partials 36 39 +3
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Wow, great work! Got a couple of comments, in any case I think we can merge now |
nice. I meet the same EOF error in v1.5.2. |
fix #173