Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image variation implementation and fix #149 #153

Merged
merged 8 commits into from
Mar 15, 2023
Merged

Add image variation implementation and fix #149 #153

merged 8 commits into from
Mar 15, 2023

Conversation

itegel
Copy link
Contributor

@itegel itegel commented Mar 14, 2023

@sashabaranov
Copy link
Owner

@itegel there's some issue with CI workflow, could you please re-base on the master branch?

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #153 (f1ca475) into master (f4a6a99) will increase coverage by 0.17%.
The diff coverage is 58.33%.

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   50.19%   50.36%   +0.17%     
==========================================
  Files          16       16              
  Lines         516      548      +32     
==========================================
+ Hits          259      276      +17     
- Misses        201      211      +10     
- Partials       56       61       +5     
Impacted Files Coverage Δ
image.go 48.27% <58.33%> (+2.82%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@itegel
Copy link
Contributor Author

itegel commented Mar 15, 2023

@itegel there's some issue with CI workflow, could you please re-base on the master branch?
Hi,

  1. I`ve fixed the lint problem.
  2. The Codeball problem seems to be related to repo permissions. Here is the suggestion from the codeball owner, you may need to install "Codeball AI Writer" on the repo. I do not know to fix it, please help me

/*
Forks and public repositories
GitHub does not offer (and reasonably so) a way for Pull Requests from a fork to a public repository to run with "write" permissions to the parent repository.
If you want to use Codeball on a public repository, install the "Codeball AI Writer" app on the parent repository. This allows the Codeball Action to use the permissions from the app as a fallback if the action is running without write permissions.
*/

@sashabaranov
Copy link
Owner

looks good, thank you!

@sashabaranov sashabaranov merged commit 1a123fe into sashabaranov:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants