fix: reduct unwanted output

: hotfix/reduce-output

Author: sascha-andres

logger.fish

@@ -1,7 +1,5 @@
 #!/usr/bin/env fish
 
-set -q shared_logger_sh_loaded; or set -g shared_logger_sh_loaded 0
-
 if test 1 -eq $shared_logger_sh_loaded
   # if [ "x1" == "x${shared_debug}" ]; then
     echo "logger.sh already included"

module.fish

@@ -1,30 +1,18 @@
 #! /usr/bin/env fish
 
+set -g shared_logger_sh_loaded 0
+
 set -q shared_module_loaded; or set -g shared_module_loaded 0
 set -q shared_debug; or set -g shared_debug 0
 set -q shared_install_location; or set -g shared_install_location "/opt/sascha-andres/shell"
 
 set -g shared_loaded_modules
 
 if test $shared_module_loaded -eq 0
-  # set -u equivalent
-
-  # shared_pipefail=${shared_pipefail:-1}
-  # shared_exit_immediatly=${shared_exit_immediatly:-1}
-
-  # if [ "x1" == "x${shared_debug}" ]; then
-  #   set -x
-  # fi
-  # if [ "x1" == "x${shared_exit_immediatly}" ]; then
-  #   set -e
-  # fi
-  # if [ "x1" == "x${shared_pipefail}" ]; then
-  #   set -o pipefail
-  # fi
-
+  set -g shared_module_loaded 1
   function pkg_module_loaded -d "list loaded modules"
     if count $argv
-      set value $argv
+      set -l value $argv
       for mod in $shared_loaded_modules
         if [ "$mod" = "$value" ]
           return 0
@@ -35,13 +23,13 @@ if test $shared_module_loaded -eq 0
   end
 
   function pkg_import -d "import a module"
-    pkg_module_loaded $argv > /dev/null
-    if test $status -ne 0
+    set -l load_result (pkg_module_loaded $argv)
+    if test $load_result -ne 0
       if test -n $argv
         if test -e "$shared_install_location/$argv.fish"
           set -g shared_loaded_modules $shared_loaded_modules $argv
           . "$shared_install_location/$argv.fish"
-          return 0
+           return 0
         else
           echo "!! import of module '$argv' failed !!"
         end
@@ -51,5 +39,4 @@ if test $shared_module_loaded -eq 0
     end
     return 1
   end
-
 end

test.fish

@@ -11,9 +11,9 @@ end
 
 source "$shared_install_location/module.fish"
 
-pkg_module_loaded "logger"
+set -l is_loaded (pkg_module_loaded "logger")
 
-if [ $status -eq 0 ]
+if [ $is_loaded -eq 0 ]
   echo "Logger is loaded: y"
 else
   echo "Logger is loaded: n"
@@ -25,8 +25,8 @@ pkg_import execute
 
 logger_header "logger"
 
-pkg_module_loaded "logger"
-if [ $status -eq 0 ]
+set -l is_loaded (pkg_module_loaded "logger")
+if [ $is_loaded -eq 0 ]
   logger_write "Logger is loaded: y"
 else
   logger_write "Logger is loaded: n"