fix: handle absolute path destinations in dev correctly (#166)

Author: sapphi-red

.changeset/funny-results-win.md

@@ -0,0 +1,5 @@
+---
+'vite-plugin-static-copy': patch
+---
+
+fix absolute destination paths in copy targets incorrectly returning contents in dev

src/options.ts

@@ -36,7 +36,9 @@ export type Target = {
    */
   src: string | string[]
   /**
-   * destination
+   * destination path
+   *
+   * If a relative path is passed, it will be resolved from `build.outDir`.
    */
   dest: string
   /**

src/serve.ts

@@ -10,6 +10,7 @@ import {
 import { debounce } from 'throttle-debounce'
 import chokidar from 'chokidar'
 import pc from 'picocolors'
+import path from 'node:path'
 
 type FileMapValue = {
   src: string
@@ -30,14 +31,15 @@ export const servePlugin = ({
   const fileMap: FileMap = new Map()
 
   const collectFileMap = async () => {
+    const absoluteBuildOutDir = path.resolve(config.root, config.build.outDir)
     try {
       const copyTargets = await collectCopyTargets(
         config.root,
         targets,
         structured,
         silent
       )
-      updateFileMapFromTargets(copyTargets, fileMap)
+      updateFileMapFromTargets(copyTargets, fileMap, absoluteBuildOutDir)
     } catch (e) {
       if (!silent) {
         config.logger.error(formatConsole(pc.red((e as Error).toString())))

src/utils.ts

@@ -279,12 +279,22 @@ export const copyAll = async (
 
 export const updateFileMapFromTargets = (
   targets: SimpleTarget[],
-  fileMap: FileMap
+  fileMap: FileMap,
+  absoluteBuildOutDir: string
 ) => {
   fileMap.clear()
   for (const target of [...targets].reverse()) {
-    let dest = target.dest.replace(/\\/g, '/')
-    if (!dest.startsWith('/')) {
+    let dest = path.isAbsolute(target.dest)
+      ? path.relative(absoluteBuildOutDir, target.dest)
+      : target.dest
+    dest = dest.replace(/\\/g, '/')
+    if (path.isAbsolute(dest) || dest.startsWith('../')) {
+      // outside buildOutDir
+      continue
+    }
+    if (dest.startsWith('./')) {
+      dest = dest.slice(1)
+    } else if (!dest.startsWith('/')) {
       dest = `/${dest}`
     }
 

test/fixtures/vite.config.ts

@@ -1,6 +1,10 @@
+import path from 'node:path'
+import { fileURLToPath } from 'node:url'
 import { defineConfig } from 'vite'
 import { viteStaticCopy } from 'vite-plugin-static-copy'
 
+const _dirname = path.dirname(fileURLToPath(import.meta.url))
+
 const wait = (delay: number) =>
   new Promise(resolve => {
     setTimeout(resolve, delay)
@@ -136,6 +140,10 @@ export default defineConfig({
             return `${filename}.foo`
           }
         },
+        {
+          src: 'foo.txt',
+          dest: path.resolve(_dirname, 'dist/fixture13')
+        },
         { src: 'eexist/*', dest: 'eexist' },
         { src: 'eexist/*', dest: 'Eexist' }
       ]

test/testcases.ts

@@ -136,6 +136,11 @@ export const testcases: Record<string, Testcase[]> = {
       dest: '/fixture12/foo.foo',
       contentType: ''
     },
+    {
+      name: 'absolute path dest',
+      src: './foo.txt',
+      dest: '/fixture13/foo.txt'
+    },
     {
       name: 'parallel copy to same dir (1)',
       src: './eexist/a/1.txt',