Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron-12 #50

Merged
merged 23 commits into from
Mar 30, 2021
Merged

electron-12 #50

merged 23 commits into from
Mar 30, 2021

Conversation

sanosdole
Copy link
Owner

Implement support for Electron 12.

Major changes:

  • node #30782 New ArrayBuffer backing store prevents reusing the same data pointer
  • electron #27949 Context isolation is turned on by default and prevents coreclr-hosting from working properly
  • electron #18397 & electron #454 lead to app.allowRendererProcessReuse being fixed to true on Electron 12. This required making coreclr-hosting context aware and implement proper re-use of the hosted CLR.

Known Issues:

  • After reloading a renderer app the task scheduler sometimes hangs up, as the the ThreadSafeFunction does not get invoked.

Code cleanup and small memory management improvements.

@sanosdole
Electron renderer example works without contextIsolation
656eef9
@sanosdole
Implemented electron example by publishing require to the renderer app
a8c1b19
@sanosdole
Added preload script to electron-blazor sample
5058a8a
@sanosdole
Rudimentary fixed reloading in same process
746b1e4
@sanosdole
We require NAPI_VERSION > 5 now.
4dba2bb 
This means at least node 12.17 & electron 11
@sanosdole
Removed some gcc warnings
46f8f43
@sanosdole
Disabled proper cleanup of CLR to test if this causes nix builds to fail
5f0f06b
@sanosdole
Removed reorder warning
af374a8
@sanosdole
Removed debug code
6d922b3
@sanosdole
Re-enabled shutdown for CLR-Hosting
64e2db9
@sanosdole
Disabled clean up for non-windows systems
9259cea
@sanosdole
ElectronHostedBlazor uses a JS ArrayBuffer for rendering
e5936d6
@sanosdole
Adapted passing of .Net or native memory to JS to new ArrayBuffer bac…
097c5ac 
…king store implementation

We have to ensure that we do not pass the same memory multiple times to JS.
This is done by using a `map` of memory already passed to JS.

This lead to improving the `NativeMemory` API and making it more safe. Published native memory is pooled now and only reference counted handles to it are accessed.
@sanosdole
Reset the active thread in NodeTaskScheduler so we are forced to set …
f3a6fc9 
…up the SynchronizationContext and TaskScheduler whenever on a JS only thread.
@sanosdole
Disable OSX homebrew update to test if it hangs the build
3e90561
@sanosdole
Disable travis cache as it fails
3b69c34
@sanosdole
re-enabled homebrew update
9ad9ee5
@sanosdole
Test newer OSX
c97ea94
@sanosdole
Enabled cache again
7222c91
@sanosdole
Abort thread safe function on close, so it is no longer triggered a…
b19dbf6 
…fter the context closes.
@sanosdole
Calling release for dotnet functions and buffers when deleting the co…
f251c6a 
…ntext to prevent memory leaks
@sanosdole
Bumped version to 0.8.0
ec1b90a
@sanosdole
Added editorconfig and applied code cleanup for C# sources.
8e5d996
@sanosdole sanosdole merged commit 4a40d5a into master Mar 30, 2021
@sanosdole sanosdole deleted the electron-12 branch March 30, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sanosdole