All plugins loaded using pytest_plugins must be optional hooks

[goodboy]

Due to pytest-dev/pytest#1821 we are currently stuck annotating all external plugins which use the pytest_plugins attribute with:

@pytest.hookimpl(optionalhook=True)
def pytest_lab_addroles(config, rolemanager):
     ...

It would be much preferable to have the pluggy.PluginManager.check_pending() call in pytest be invoked after the historic call to pytest_addhooks() to avoid this early validation error. It's that or we have to use our own plugin manager instance.

[goodboy]

Misfire on this one.
Fixed by using entry points in ba12575.